From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laszlo Ersek Subject: Re: [Qemu-devel] How to reserve guest physical region for ACPI Date: Thu, 7 Jan 2016 18:08:02 +0100 Message-ID: <568E9B72.6000304@redhat.com> References: <1449040860-19040-1-git-send-email-guangrong.xiao@linux.intel.com> <5680A0C8.6040505@linux.intel.com> <20151228141917-mutt-send-email-mst@redhat.com> <20151230165554.4d15e5a4@nial.brq.redhat.com> <20151230213740-mutt-send-email-mst@redhat.com> <20160105173025.4aa4e69f@nial.brq.redhat.com> <20160105183211-mutt-send-email-mst@redhat.com> <20160107113025.32cc5b52@nial.brq.redhat.com> <20160107123214-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net To: "Michael S. Tsirkin" , Igor Mammedov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47894 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbcAGRIH (ORCPT ); Thu, 7 Jan 2016 12:08:07 -0500 In-Reply-To: <20160107123214-mutt-send-email-mst@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/07/16 11:54, Michael S. Tsirkin wrote: > On Thu, Jan 07, 2016 at 11:30:25AM +0100, Igor Mammedov wrote: >> On Tue, 5 Jan 2016 18:43:02 +0200 >> "Michael S. Tsirkin" wrote: >> >>> On Tue, Jan 05, 2016 at 05:30:25PM +0100, Igor Mammedov wrote: ... >>>>>>> An alternative is to add an XSDT, XP ignores that. >>>>>>> XSDT at the moment breaks OVMF (because it loads both >>>>>>> the RSDT and the XSDT, which is wrong), but I think >>>>>>> Laszlo was working on a fix for that. >>>>>> Using XSDT would increase ACPI tables occupied RAM >>>>>> as it would duplicate DSDT + non XP supported AML >>>>>> at global namespace. >>>>> >>>>> Not at all - I posted patches linking to same >>>>> tables from both RSDT and XSDT at some point. >>>>> Only the list of pointers would be different. >>>> if you put XP incompatible AML in separate SSDT and link it >>>> only from XSDT than that would work but if incompatibility >>>> is in DSDT, one would have to provide compat DSDT for RSDT >>>> an incompat DSDT for XSDT. >>> >>> So don't do this. >> well spec says "An ACPI-compatible OS must use the XSDT if present", >> which I read as tables pointed by RSDT MUST be pointed by XSDT >> as well and RSDT MUST NOT not be used. >> >> so if we put incompatible changes in a separate SSDT and put >> it only in XSDT that might work. Showstopper here is OVMF which >> has issues with it as Laszlo pointed out. > > But that's just a bug. Yes, but the bug (actually: lack of feature) is in the UEFI specification. The current EFI_ACPI_TABLE_PROTOCOL implementation in edk2 conforms to the specification. In order to expose the functionality that the above trick needs, the UEFI spec has to be changed. In my (limited, admittedly) experience, that's an uphill battle. [...]