From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrey Smetanin <asmetanin@virtuozzo.com>
Subject: Re: [PATCH v1 3/6] kvm/x86: Reorg stimer_expiration() to better
 control timer restart
Date: Thu, 7 Jan 2016 23:13:35 +0300
Message-ID: <568EC6EF.90102@virtuozzo.com>
References: <1450870121-15943-1-git-send-email-asmetanin@virtuozzo.com>
 <1450870121-15943-4-git-send-email-asmetanin@virtuozzo.com>
 <568E93AE.1050401@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Gleb Natapov <gleb@kernel.org>, Roman Kagan <rkagan@virtuozzo.com>,
	"Denis V. Lunev" <den@openvz.org>, <qemu-devel@nongnu.org>
To: Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.parallels.com ([199.115.105.18]:48363 "EHLO
	mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751534AbcAGUOZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 7 Jan 2016 15:14:25 -0500
In-Reply-To: <568E93AE.1050401@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 01/07/2016 07:34 PM, Paolo Bonzini wrote:
>
>
> On 23/12/2015 12:28, Andrey Smetanin wrote:
>> -	stimer_send_msg(stimer);
>> -	if (!(stimer->config & HV_STIMER_PERIODIC))
>> -		stimer->config |= ~HV_STIMER_ENABLE;
>> -	else
>> -		stimer_start(stimer);
>> +	stimer->msg_pending = true;
>> +	if (!stimer_send_msg(stimer)) {
>> +		stimer->msg_pending = false;
>> +		if (!(stimer->config & HV_STIMER_PERIODIC))
>> +			stimer->config |= ~HV_STIMER_ENABLE;
>
> Just because this is curious: sure it shouldn't be "&="?
You are right, we found it too late - only by testing Linux guest 
Hyper-v timers which are one-shot timers. We have fixed it in v2.
>
> Paolo
>
>> +	}