From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: [PATCH v8 20/20] KVM: ARM64: Add a new kvm ARM PMU device Date: Fri, 8 Jan 2016 11:06:16 +0800 Message-ID: <568F27A8.80808@huawei.com> References: <1450771695-11948-1-git-send-email-zhaoshenglong@huawei.com> <1450771695-11948-21-git-send-email-zhaoshenglong@huawei.com> <568E7AF1.9040103@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: arm-mail-list , kvm-devel , Marc Zyngier , Will Deacon , Shannon Zhao , "kvmarm@lists.cs.columbia.edu" To: Peter Maydell Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On 2016/1/7 22:56, Peter Maydell wrote: >>>> + Errors: >>>> >>> + -ENXIO: Unsupported attribute group >>>> >>> + -EBUSY: The PMU overflow interrupt is already set >>>> >>> + -ENODEV: Getting the PMU overflow interrupt number while it's not set >>>> >>> + -EINVAL: Invalid vcpu_index or PMU overflow interrupt number supplied >>> >> >>> >> What happens if you create a PMU but then never set the IRQ number? >>> >> Is there a default or does the VM refuse to run or something? >>> >> >> > If userspace doesn't specify the irq number, the guest will not receive >> > the PMU interrupt because we check if the irq is initialized when we >> > inject the interrupt. But guest could still use the vPMU if QEMU >> > generates a proper DTB or ACPI. > So is it a valid use case to create a PMU with the interrupt not wired > up to anything? (If it's never valid it would be nice to diagnose it > rather than just silently letting the guest run but not work right.) So how about adding a helper to check if the PMU is completely initialized and if not, return trap_raz_wi when guest access PMU registers? Thanks, -- Shannon