From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 5/6] nvdimm acpi: let qemu handle _DSM method Date: Fri, 8 Jan 2016 12:01:54 +0800 Message-ID: <568F34B2.9090101@linux.intel.com> References: <1451933528-133684-1-git-send-email-guangrong.xiao@linux.intel.com> <1451933528-133684-6-git-send-email-guangrong.xiao@linux.intel.com> <20160107152228.2676222a@nial.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net To: Igor Mammedov Return-path: In-Reply-To: <20160107152228.2676222a@nial.brq.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 01/07/2016 10:22 PM, Igor Mammedov wrote: > On Tue, 5 Jan 2016 02:52:07 +0800 > Xiao Guangrong wrote: > >> If dsm memory is successfully patched, we let qemu fully emulate >> the dsm method >> >> This patch saves _DSM input parameters into dsm memory, tell dsm >> memory address to QEMU, then fetch the result from the dsm memory > you also need to add NVDR._CRS method that would report > resources used by operation regions. I can not understand this point, why we need to report the resource of OperationRegion? It is ACPI internally used anyway. > > NVDIMM_COMMON_DSM - probably should be serialized, otherwise > there is a race risk, when several callers would write to > control region. Yes, i did it in patch 6/6, but definitely i should more it to here.