kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
To: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/4] KVM: renumber architecture-dependent requests
Date: Fri, 8 Jan 2016 15:01:34 +0900	[thread overview]
Message-ID: <568F50BE.209@lab.ntt.co.jp> (raw)
In-Reply-To: <1452176228-8484-4-git-send-email-pbonzini@redhat.com>

On 2016/01/07 23:17, Paolo Bonzini wrote:
> Leave room for 4 more arch-independent requests.

In the current requests handling code, this ordering means
that architecture specific requests get handled only after
generic ones.

If someone wants to make a generic request that needs to be
handled before entering the guest from any architecture
specific request handler, this can be a problem.

If you can guarantee that this kind of dependencies will not
be introduced in the future, this change looks good to me.

Actually, I want to make the current dependencies, even between
architecture specific requests, more explicitly written in the
code.

  Takuya

  parent reply	other threads:[~2016-01-08  6:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 14:17 [PATCH 0/4] Reorganize request bits Paolo Bonzini
2016-01-07 14:17 ` [PATCH 1/4] KVM: Remove unused KVM_REQ_KICK to save a bit in Paolo Bonzini
2016-01-07 14:26   ` Christian Borntraeger
2016-01-07 14:17 ` [PATCH 2/4] KVM: document which architecture uses each request bit Paolo Bonzini
2016-01-07 14:38   ` Christian Borntraeger
2016-01-07 14:17 ` [PATCH 3/4] KVM: renumber architecture-dependent requests Paolo Bonzini
2016-01-07 15:27   ` Christian Borntraeger
2016-01-07 15:45     ` Paolo Bonzini
2016-01-07 15:50       ` Christian Borntraeger
2016-01-08  6:01   ` Takuya Yoshikawa [this message]
2016-01-07 14:17 ` [PATCH 4/4] KVM: move architecture-dependent requests to arch/ Paolo Bonzini
2016-01-07 15:54   ` Christian Borntraeger
2016-01-07 16:04     ` Paolo Bonzini
2016-01-07 14:23 ` [PATCH 0/4] Reorganize request bits Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568F50BE.209@lab.ntt.co.jp \
    --to=yoshikawa_takuya_b1@lab.ntt.co.jp \
    --cc=borntraeger@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).