From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH v10 12/12] ppc64: Introduce lib/ppc64/asm/barrier.h Date: Mon, 13 Jun 2016 15:34:53 +0200 Message-ID: <568ceb38-ba54-b855-ee79-166327a7c8f1@redhat.com> References: <0f5c8998a7ed12dd1bccd5ee2318ec9c7a371c4b.1465207665.git.agordeev@redhat.com> <20160606122250.mss5ntmodhxm6tap@hawk.localdomain> <20160610063654.GB11036@dhcp-27-118.brq.redhat.com> <20160610070152.6pkjvkf5ihjv4n2g@hawk.localdomain> <20160610070820.agqazvvufk3uohht@hawk.localdomain> <20160610081719.GA28512@dhcp-27-118.brq.redhat.com> <20160613104925.ndn7bwccbwvnpqbd@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Thomas Huth , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= To: Andrew Jones , Alexander Gordeev Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:36457 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423357AbcFMNfC (ORCPT ); Mon, 13 Jun 2016 09:35:02 -0400 Received: by mail-wm0-f66.google.com with SMTP id m124so14928364wme.3 for ; Mon, 13 Jun 2016 06:35:01 -0700 (PDT) In-Reply-To: <20160613104925.ndn7bwccbwvnpqbd@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 13/06/2016 12:49, Andrew Jones wrote: >> + >> +#ifndef mb >> +#define mb() asm volatile("":::"memory") >> +#endif >> +#ifndef rmb >> +#define rmb() asm volatile("":::"memory") >> +#endif >> +#ifndef wmb >> +#define wmb() asm volatile("":::"memory") >> +#endif This is certainly wrong for PPC64. Paolo