From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 02/12] scripts/mkstandalone: fix ARCH
Date: Tue, 19 Jan 2016 15:32:39 +0100
Message-ID: <569E4907.4060202@redhat.com>
References: <1453209851-27760-1-git-send-email-rkrcmar@redhat.com>
 <1453209851-27760-3-git-send-email-rkrcmar@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Andrew Jones <drjones@redhat.com>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
	kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57339 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754088AbcASOcn (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 19 Jan 2016 09:32:43 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id 52CB64C524
	for <kvm@vger.kernel.org>; Tue, 19 Jan 2016 14:32:43 +0000 (UTC)
In-Reply-To: <1453209851-27760-3-git-send-email-rkrcmar@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 19/01/2016 14:24, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
> ARCH depends on the built image, not on target's arch.
> Use the value from config.mak.
>=20
> Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
> ---
>  scripts/mkstandalone.sh | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
>=20
> diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh
> index 5f9ef146208e..47d6e279d212 100755
> --- a/scripts/mkstandalone.sh
> +++ b/scripts/mkstandalone.sh
> @@ -53,17 +53,8 @@ function mkstandalone()
> =20
>  	echo "#!/bin/sh"
> =20
> -if [ "$arch" ]; then
> -	cat <<EOF
> -ARCH=3D\`uname -m | sed -e s/i.86/i386/ | sed -e 's/arm.*/arm/'\`
> -[ "\$ARCH" =3D "aarch64" ] && ARCH=3D"arm64"
> -if [ "\$ARCH" !=3D "$arch" ]; then
> -	echo "skip $testname ($arch only)" 1>&2
> -	exit 1
> -fi
> +	cat config.mak | grep '^ARCH=3D'

Useless use of cat... so far nothing that I cannot fix myself.

Paolo

> =20
> -EOF
> -fi
>  if [ "$check" ]; then
>  	cat <<EOF
>  for param in $check; do
>=20