From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH kvm-unit-tests 00/12] scripts/mkstandalone: rewrite Date: Tue, 19 Jan 2016 15:49:10 +0100 Message-ID: <569E4CE6.4060702@redhat.com> References: <1453209851-27760-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Jones To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34901 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755678AbcASOtP (ORCPT ); Tue, 19 Jan 2016 09:49:15 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id A2B327AE94 for ; Tue, 19 Jan 2016 14:49:14 +0000 (UTC) In-Reply-To: <1453209851-27760-1-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 19/01/2016 14:23, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > Drew and I have shelved series' where mkstandalone was duplicating th= e > effort. This patchset should make future changes much simpler by > reusing code from other files in standalone tests. Nice! Tacked on the following at the end, and pushed. commit c8104a66356d03d5dbb264422023297e8ec34652 Author: Paolo Bonzini Date: Tue Jan 19 15:47:48 2016 +0100 scripts/mkstandalone: document what it writes to Makes it a bit less puzzling. :) Signed-off-by: Paolo Bonzini diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh index 1e0da8e..5891005 100755 --- a/scripts/mkstandalone.sh +++ b/scripts/mkstandalone.sh @@ -71,6 +71,7 @@ function mkstandalone() generate_test "$@" > $standalone chmod +x $standalone + echo Written $standalone. return 0 } Paolo