From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v3 1/4] KVM: Recover IRTE to remapped mode if the interrupt is not single-destination Date: Mon, 25 Jan 2016 13:22:38 +0100 Message-ID: <56A6138E.9060805@redhat.com> References: <1453254177-103002-1-git-send-email-feng.wu@intel.com> <1453254177-103002-2-git-send-email-feng.wu@intel.com> <20160121161949.GA14104@potion.brq.redhat.com> <20160122130551.GA23362@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" To: =?UTF-8?Q?Radim_Krcm=c3=a1r?= , "Wu, Feng" Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:34624 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756142AbcAYMWo (ORCPT ); Mon, 25 Jan 2016 07:22:44 -0500 In-Reply-To: <20160122130551.GA23362@potion.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 22/01/2016 14:05, Radim Krcm=C3=A1r wrote: > > This is a good question. I also thought about this before, but afte= r > > thinking it a bit more, seems we don't need to do this.=20 > > If we don't do this, the in-flight interrupts will continue to be > > delivered in PI mode while we are changing it to remapped > > mode in IRTE. Even if we do this, the in-flight interrupts are > > also delivered in PI mode before setting 'SN' anyway, so seems > > we really don't need this, what is your opinion? > I'd remove it. It may be necessary because IRTE writes (128 bits) are not atomic. If so, no need to send v5, I'll add it back. Paolo