From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v4 4/5] util: [ppc] Use new error_report_abort() instead
 of abort()
Date: Thu, 28 Jan 2016 14:45:58 -0700
Message-ID: <56AA8C16.3090602@redhat.com>
References: <145401727502.31479.11571397180565966513.stgit@localhost>
 <145401729734.31479.15887562149880928240.stgit@localhost>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="qB2pGxVBPsQ3Qj4ilGQGPAVMh9CD0BT0R"
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"open list:PowerPC" <qemu-ppc@nongnu.org>,
	"open list:Overall" <kvm@vger.kernel.org>
To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= <vilanova@ac.upc.edu>,
	qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58849 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S934134AbcA1VqD (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 28 Jan 2016 16:46:03 -0500
In-Reply-To: <145401729734.31479.15887562149880928240.stgit@localhost>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qB2pGxVBPsQ3Qj4ilGQGPAVMh9CD0BT0R
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/28/2016 02:41 PM, Llu=C3=ADs Vilanova wrote:
> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> ---
>  target-ppc/kvm.c        |    4 ++--
>  target-ppc/kvm_ppc.h    |   15 +++++++++------
>  target-ppc/mmu-hash32.c |    5 +++--
>  target-ppc/mmu_helper.c |    3 +--
>  4 files changed, 15 insertions(+), 12 deletions(-)
>=20

> +++ b/target-ppc/kvm_ppc.h
> @@ -9,6 +9,9 @@
>  #ifndef __KVM_PPC_H__
>  #define __KVM_PPC_H__
> =20
> +#include "qemu/error-report.h"
> +
> +
>  #define TYPE_HOST_POWERPC_CPU "host-" TYPE_POWERPC_CPU
> =20
>  #ifdef CONFIG_KVM
> @@ -220,36 +223,36 @@ static inline int kvmppc_get_htab_fd(bool write)
>  static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize=
,
>                                     int64_t max_ns)
>  {
> -    abort();
> +    error_report_abort(" ");

Aborting with an empty string with trailing spaces feels awkward.
Either this should be a real message, or abort() was just fine.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--qB2pGxVBPsQ3Qj4ilGQGPAVMh9CD0BT0R
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJWqowWAAoJEKeha0olJ0Nqy14H+wVxmj7v+IAP28BBQ3TDhxAR
oCyFoxqPGoW5xZD6ufhlyW+dDVx5HJraaWE6S1kg9qigIcUuz5VHnL1UqphxSq9U
37bouxOrV0LK2lsg/TMKzsd9o0pkQcQhyzbNKs0ljMpdXiiSQT/kIdKoIOtir2xG
3MHIBCrdu5OJlzFF985uEMvBsrBdZkfuypuFaG2wCYQxglzbQJnw5CUR8eObEanw
Svf7YAMyZZeyOCIcnf2GVZ/7HPNClsjyirxwA511ORb0V6pCigTwsz/hVfNS04p0
bsSvskflur5Jy3TJHFzKcwPcH2mtjY+kHrSmcl8r9PFA+SRRIMM3QdzyKy1sgrQ=
=mxpV
-----END PGP SIGNATURE-----

--qB2pGxVBPsQ3Qj4ilGQGPAVMh9CD0BT0R--