From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM Date: Tue, 2 Feb 2016 20:37:12 +0100 Message-ID: <56B10568.8020609@de.ibm.com> References: <56576FD6.40506@de.ibm.com> <56581A59.4080705@de.ibm.com> <565C0B1F.7070606@de.ibm.com> <56B0E448.1020509@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: frankja@linux.vnet.ibm.com, kvm@vger.kernel.org, pmorel@linux.vnet.ibm.com, dan.carpenter@oracle.com, "Kevin's boot bot" To: Paolo Bonzini , Tyler Baker Return-path: Received: from e06smtp09.uk.ibm.com ([195.75.94.105]:54584 "EHLO e06smtp09.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754376AbcBBThR (ORCPT ); Tue, 2 Feb 2016 14:37:17 -0500 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 2 Feb 2016 19:37:16 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1CE6B1B08061 for ; Tue, 2 Feb 2016 19:37:24 +0000 (GMT) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u12JbDuE49872972 for ; Tue, 2 Feb 2016 19:37:13 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u12JbCX6003224 for ; Tue, 2 Feb 2016 12:37:13 -0700 In-Reply-To: <56B0E448.1020509@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/02/2016 06:15 PM, Paolo Bonzini wrote: > > > On 30/11/2015 09:38, Christian Borntraeger wrote: >> >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index f7d6c8f..b26472a 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -671,12 +671,16 @@ static struct kvm *kvm_create_vm(unsigned long type) >> >> r = kvm_create_vm_debugfs(kvm); >> if (r) >> - goto out_err; >> + goto out_mmu; >> >> preempt_notifier_inc(); >> >> return kvm; >> >> +out_mmu: >> +#if defined(CONFIG_MMU_NOTIFIER) && defined(KVM_ARCH_WANT_MMU_NOTIFIER) >> + mmu_notifier_unregister(&kvm->mmu_notifier, kvm->mm); >> +#endif >> out_err: >> cleanup_srcu_struct(&kvm->irq_srcu); >> out_err_no_irq_srcu: > > Looking at old unread email in my inbox... can you resubmit this to > kvm@vger.kernel.org as a proper patch (Signed-off-by, commit message, etc.)? > This patch was only necessary to fixup an earlier version of Janosch's patch. upstream is fine.