From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: Create debugfs statistics for each VM
Date: Thu, 4 Feb 2016 14:05:43 +0100
Message-ID: <56B34CA7.4040107@redhat.com>
References: <1453996159-19576-1-git-send-email-frankja@linux.vnet.ibm.com>
 <1453996159-19576-2-git-send-email-frankja@linux.vnet.ibm.com>
 <56B0B9AF.3010305@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, dan.carpenter@oracle.com
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Janosch Frank <frankja@linux.vnet.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58955 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932465AbcBDNFt (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 4 Feb 2016 08:05:49 -0500
In-Reply-To: <56B0B9AF.3010305@de.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 02/02/2016 15:14, Christian Borntraeger wrote:
> FWIW, the newly created subfolders,
> 
> require QEMU commit 6590045e5dd2fb0b1d7cdc047ae0c52fd4bb5276
>     scripts/kvm/kvm_stat: Replaced os.listdir with os.walk
> 
> Otherwise you might get errors like 
> 
> Traceback (most recent call last):
>   File "scripts/kvm/kvm_stat", line 640, in <module>
>     curses.wrapper(tui, stats)
>   File "/usr/lib64/python2.7/curses/wrapper.py", line 43, in wrapper
>     return func(stdscr, *args, **kwds)
>   File "scripts/kvm/kvm_stat", line 547, in tui
>     refresh(sleeptime)
>   File "scripts/kvm/kvm_stat", line 523, in refresh
>     s = stats.get()
>   File "scripts/kvm/kvm_stat", line 483, in get
>     new = d.read()
>   File "scripts/kvm/kvm_stat", line 37, in read
>     return dict([(key, val(key)) for key in self._fields])
>   File "scripts/kvm/kvm_stat", line 36, in val
>     return int(file(self.base + '/' + key).read())
> IOError: [Errno 21] Is a directory: '/sys/kernel/debug/kvm/13123-31'
> 
> when using the "-d" option.
> 
> 
> Paolo, I still think that this a valuable addon for debugging. Any guidance?

Yeah, I agree...  Do we want to add a module parameter for this, and/or
a kernel configuration that for now defaults to N?

An alternative is to move kvm_stat from QEMU to tools/.

Paolo