Re: [PATCH V1 0/7] Enable ACPI support for ARM KVM GIC

Julien Grall
2016-02-08T16:39:49Z

Hi,

On 08/02/16 09:59, Marc Zyngier wrote:
> On 05/02/16 17:07, Wei Huang wrote:
>> Wei Huang (7):
>> KVM: GIC: Move GIC DT probing code to GICv2 and GICv3 files
>> KVM: GIC: Add extra fields to store GICH and GICV resource info
>> KVM: GIC: Create a common probe function for GIC
>> KVM: GICv2: Extract the common code from DT
>> KVM: GICv2: Add ACPI probing function
>> KVM: GICv3: Extract the common code from DT
>> KVM: GICv3: Add ACPI probing function
>>
>> include/kvm/arm_vgic.h | 14 ++--
>> virt/kvm/arm/vgic-v2-emul.c | 4 +-
>> virt/kvm/arm/vgic-v2.c | 186 +++++++++++++++++++++++++++++++++-----------
>> virt/kvm/arm/vgic-v3.c | 159 ++++++++++++++++++++++++++++---------
>> virt/kvm/arm/vgic.c | 22 +-----
>> 5 files changed, 277 insertions(+), 108 deletions(-)
>>
>
> So when I see this diffstat and the patches that follow, I cannot help
> but think that we do have a disconnect here. You do add a bunch of ACPI
> probing in KVM, to which I've already said no.
>
> I want to see the probing code in the GIC drivers, exported through a
> common structure that KVM can then use. That's it. Nothing else.

I've been working on a patch series which rely on the GIC and arch timer
drivers to get the necessary information to initialize the different KVM
components (vGIC + vtimer).

I think this achieves the goal you have in mind. I will post the series
in a few minutes.

Regards,

--
Julien Grall