From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH v2 00/14] ppc64: initial drop Date: Wed, 10 Feb 2016 15:27:09 +0100 Message-ID: <56BB48BD.2040305@redhat.com> References: <1454957594-30601-1-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: thuth@redhat.com, dgibson@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de, lvivier@redhat.com To: Andrew Jones , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59740 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbcBJO1N (ORCPT ); Wed, 10 Feb 2016 09:27:13 -0500 In-Reply-To: <1454957594-30601-1-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/02/2016 19:53, Andrew Jones wrote: > It's been a loooong time since I posted v1 of this series, but thanks > to Thomas' poking, and even volunteering to help move v2 along, I've > finally picked it back up. > > v2: > Besides rebasing on latest master, v2 addresses all of David's comments > - assembler cleanup > - jump into the RTAS blob we get from DT, instead of reproducing it > - don't store the RTAS root node, always hunt it down > > v2 didn't address debug-exit, and we still need a solution for that. > Plugging chr-testdev into an spapr vty is probably what we should > investigate first (as was suggested by Alex Graf under the v1 review). > For this v2 I just kept the hack from v1, but simplified it and > explicitly call it out as the hack that it is. > > Additional known issues: > Latest F22 cross-compiler (gcc5 based) doesn't generate working > code with this series. I didn't try to debug. The 4.9 based compiler > I initially used on v1 works, so I reverted to that one. > > Testing: > I only tested with qemu-system-ppc64 (latest) on x86_64 so far. I'll > try to get a machine to test with real hardware (and KVM) unless > someone (hi Thomas :-) beats me to it. > > Standard cover-letter summary: > This series brings basic setup; starts a test's C entry point, main(), > and printf, exit, and malloc work. Three more series should follow this > one which must bring; vector support, mmu support, and smp support, at > which point I believe the framework could just evolve with the creation > of unit tests. > > Patches also available here > https://github.com/rhdrjones/kvm-unit-tests/commits/ppc64/initial-drop-v2 The only request is to not include zero-size files; just leave them out and add them as necessary. Otherwise it's nice. :) Paolo