From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Huth <thuth@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v2 08/14] powerpc/ppc64: add HV putchar
Date: Fri, 12 Feb 2016 18:08:23 +0100
Message-ID: <56BE1187.8050502@redhat.com>
References: <1454957594-30601-1-git-send-email-drjones@redhat.com>
 <1454957594-30601-9-git-send-email-drjones@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dgibson@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de,
	lvivier@redhat.com, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:51446 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750886AbcBLRI2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 12 Feb 2016 12:08:28 -0500
In-Reply-To: <1454957594-30601-9-git-send-email-drjones@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 08.02.2016 19:53, Andrew Jones wrote:
> Add the hvcall for putchar and use it in puts. That, along with a
> couple more lines in start to prepare for C code, and a branch to
> main(), gets us "hello world". Run with
> 
> qemu-system-ppc64 -M pseries            \
>         -bios powerpc/boot_rom.bin      \
>         -display none -serial stdio     \
>         -kernel powerpc/selftest.elf
> 
> (We're still not relocating yet, that comes in a later patch. Thus,
>  testing hello-world at this point requires a hacked QEMU and linking
>  the unit test at QEMU's kernel load address.)

Is that comment still valid? I thought that's what the boot_rom.bin was
good for?

Apart from that, this patch looks fine to me.

 Thomas