From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org,
mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
imammedo@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com, rth@twiddle.net
Subject: Re: [PATCH v2 02/11] tests: acpi: test NVDIMM tables
Date: Sun, 14 Feb 2016 13:36:32 +0800 [thread overview]
Message-ID: <56C01260.1080708@linux.intel.com> (raw)
In-Reply-To: <20160204181721-mutt-send-email-mst@redhat.com>
On 02/05/2016 12:20 AM, Michael S. Tsirkin wrote:
> On Wed, Jan 13, 2016 at 02:50:01AM +0800, Xiao Guangrong wrote:
>> Add nvdimm test, two tables are created which are NFIT and
>> SSDT
>>
>> Max memory size and multiple slots are needed to enable NVDIMM which
>> cause the primal SSDT table is also updated
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>
> First don't include binary in patches directly please.
Okay.
>
>> ---
>> tests/acpi-test-data/pc/NFIT | Bin 0 -> 224 bytes
>> tests/acpi-test-data/pc/NFIT.bridge | Bin 0 -> 224 bytes
>> tests/acpi-test-data/pc/SSDT | Bin 2486 -> 2885 bytes
>> tests/acpi-test-data/pc/SSDT-NVDIMM | Bin 0 -> 134 bytes
>> tests/acpi-test-data/pc/SSDT-NVDIMM.bridge | Bin 0 -> 134 bytes
>> tests/acpi-test-data/pc/SSDT.bridge | Bin 4345 -> 4745 bytes
>> tests/acpi-test-data/q35/NFIT | Bin 0 -> 224 bytes
>> tests/acpi-test-data/q35/NFIT.bridge | Bin 0 -> 224 bytes
>> tests/acpi-test-data/q35/SSDT | Bin 691 -> 1090 bytes
>> tests/acpi-test-data/q35/SSDT-NVDIMM | Bin 0 -> 134 bytes
>> tests/acpi-test-data/q35/SSDT-NVDIMM.bridge | Bin 0 -> 134 bytes
>> tests/acpi-test-data/q35/SSDT.bridge | Bin 708 -> 1107 bytes
>> tests/bios-tables-test.c | 15 ++++++++++-----
>
> So let's add an new test, and there only test the NVDIMM tables and only
> with one configuration.
>
> Otherwise number of tables to maintain explodes.
>
> You will have to teach test to ignore everything
> that does not have NVDIMM in name for this test.
>
Okay, i will it as the single test and make it as a separate patchset.
next prev parent reply other threads:[~2016-02-14 5:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 18:49 [PATCH v2 00/11] NVDIMM ACPI: introduce the framework of QEMU emulated Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 01/11] tests: acpi: test multiple SSDT tables Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 02/11] tests: acpi: test NVDIMM tables Xiao Guangrong
2016-02-04 16:20 ` Michael S. Tsirkin
2016-02-14 5:36 ` Xiao Guangrong [this message]
2016-01-12 18:50 ` [PATCH v2 03/11] acpi: add aml_create_field() Xiao Guangrong
2016-02-08 10:47 ` Igor Mammedov
2016-02-14 5:41 ` Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 04/11] acpi: add aml_concatenate() Xiao Guangrong
2016-02-08 10:51 ` Igor Mammedov
2016-02-14 5:52 ` Xiao Guangrong
2016-02-14 5:55 ` Xiao Guangrong
2016-02-15 9:02 ` Igor Mammedov
2016-02-15 10:32 ` Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 05/11] acpi: allow using object as offset for OperationRegion Xiao Guangrong
2016-02-08 10:57 ` Igor Mammedov
2016-01-12 18:50 ` [PATCH v2 06/11] nvdimm acpi: initialize the resource used by NVDIMM ACPI Xiao Guangrong
2016-02-04 16:22 ` Michael S. Tsirkin
2016-02-08 11:03 ` Igor Mammedov
2016-02-14 5:57 ` Xiao Guangrong
2016-02-15 9:11 ` [Qemu-devel] " Igor Mammedov
2016-02-15 9:18 ` Michael S. Tsirkin
2016-02-15 10:13 ` Xiao Guangrong
2016-02-15 10:30 ` Michael S. Tsirkin
2016-02-15 10:47 ` Igor Mammedov
2016-02-15 11:22 ` Xiao Guangrong
2016-02-15 11:45 ` Michael S. Tsirkin
2016-02-15 13:32 ` Igor Mammedov
2016-02-15 15:53 ` Xiao Guangrong
2016-02-15 17:24 ` Igor Mammedov
2016-02-15 18:35 ` Xiao Guangrong
2016-02-16 11:00 ` Igor Mammedov
2016-02-17 2:04 ` Xiao Guangrong
2016-02-17 17:26 ` Michael S. Tsirkin
2016-02-18 4:03 ` Xiao Guangrong
2016-02-18 10:05 ` Igor Mammedov
2016-02-19 8:08 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-19 8:43 ` Dan Williams
2016-02-22 10:30 ` Xiao Guangrong
2016-02-22 10:34 ` Xiao Guangrong
2016-02-18 10:20 ` Michael S. Tsirkin
2016-02-15 11:36 ` Michael S. Tsirkin
2016-01-12 18:50 ` [PATCH v2 07/11] nvdimm acpi: introduce patched dsm memory Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 08/11] nvdimm acpi: let qemu handle _DSM method Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 09/11] nvdimm acpi: emulate dsm method Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 10/11] nvdimm acpi: add _CRS Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 11/11] tests: acpi: update nvdimm ssdt table Xiao Guangrong
2016-01-20 2:21 ` [PATCH v2 00/11] NVDIMM ACPI: introduce the framework of QEMU emulated Xiao Guangrong
2016-01-28 4:42 ` Xiao Guangrong
2016-02-04 16:24 ` Michael S. Tsirkin
2016-02-14 5:38 ` [Qemu-devel] " Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C01260.1080708@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).