From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 03/11] acpi: add aml_create_field() Date: Sun, 14 Feb 2016 13:41:06 +0800 Message-ID: <56C01372.10105@linux.intel.com> References: <1452624610-46945-1-git-send-email-guangrong.xiao@linux.intel.com> <1452624610-46945-4-git-send-email-guangrong.xiao@linux.intel.com> <20160208114735.7e66c036@nial.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net To: Igor Mammedov Return-path: In-Reply-To: <20160208114735.7e66c036@nial.brq.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 02/08/2016 06:47 PM, Igor Mammedov wrote: > On Wed, 13 Jan 2016 02:50:02 +0800 > Xiao Guangrong wrote: > >> It will be used by nvdimm acpi >> >> Signed-off-by: Xiao Guangrong >> --- >> hw/acpi/aml-build.c | 13 +++++++++++++ >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 14 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 78e1290..97c9efb 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -1001,6 +1001,19 @@ Aml *create_field_common(int opcode, Aml *srcbuf, Aml *index, const char *name) >> return var; >> } >> >> +/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateField */ >> +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name) > to match spec more closely pls do following: > s/index/bit_index/ > s/len/num_bits/ > Good to me, will do it in the next version.