From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH v2 04/11] acpi: add aml_concatenate()
Date: Sun, 14 Feb 2016 13:52:53 +0800
Message-ID: <56C01635.6090501@linux.intel.com>
References: <1452624610-46945-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1452624610-46945-5-git-send-email-guangrong.xiao@linux.intel.com>
	<20160208115103.00dc44db@nial.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org,
	mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net
To: Igor Mammedov <imammedo@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <20160208115103.00dc44db@nial.brq.redhat.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org



On 02/08/2016 06:51 PM, Igor Mammedov wrote:
> On Wed, 13 Jan 2016 02:50:03 +0800
> Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:
>
>> It will be used by nvdimm acpi
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>> ---
>>   hw/acpi/aml-build.c         | 14 ++++++++++++++
>>   include/hw/acpi/aml-build.h |  1 +
>>   2 files changed, 15 insertions(+)
>>
>> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
>> index 97c9efb..421dd84 100644
>> --- a/hw/acpi/aml-build.c
>> +++ b/hw/acpi/aml-build.c
>> @@ -1440,6 +1440,20 @@ Aml *aml_alias(const char *source_object, const char *alias_object)
>>       return var;
>>   }
>>
>> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefConcat */
>> +Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target)
>> +{
>> +    Aml *var = aml_opcode(0x73 /* ConcatOp */);
>> +    aml_append(var, source1);
>> +    aml_append(var, source2);
>> +
>> +    if (target) {
>> +        aml_append(var, target);
>> +    }
> target is not an optional, pls looks at aml_add and use
> helper to make patch correct and smaller
>

Indeed, i will change it to:

/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefConcat */
Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target)
{
     return  build_opcode_2arg_dst(0x73 /* ConcatOp */, arg1, arg2, dst);
}

Thank you, Igor!