From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [kvm-unit-tests PATCH v3 01/17] arm/arm64: trivial: another assert fix Date: Mon, 15 Feb 2016 07:38:38 +0100 Message-ID: <56C1726E.1050101@redhat.com> References: <1455380910-30604-1-git-send-email-drjones@redhat.com> <1455380910-30604-2-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dgibson@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de, lvivier@redhat.com, pbonzini@redhat.com To: Andrew Jones , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33769 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbcBOGim (ORCPT ); Mon, 15 Feb 2016 01:38:42 -0500 In-Reply-To: <1455380910-30604-2-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 13.02.2016 17:28, Andrew Jones wrote: > Signed-off-by: Andrew Jones > > --- > Unrelated to the powerpc initial drop, but found it while working > on that, so just posting it now. Anyway, it's a trivial fix. > --- > lib/arm/io.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/arm/io.c b/lib/arm/io.c > index a08d394e4aa1c..a111530f4802d 100644 > --- a/lib/arm/io.c > +++ b/lib/arm/io.c > @@ -50,7 +50,8 @@ static void uart0_init(void) > } > > } else { > - assert(dt_pbus_translate_node(ret, 0, &base) == 0); > + ret = dt_pbus_translate_node(ret, 0, &base); > + assert(ret == 0); > } > > uart0_base = ioremap(base.addr, base.size); Reviewed-by: Thomas Huth