From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, dgibson@redhat.com,
agraf@suse.de, lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 11/17] powerpc/ppc64: add hcall support and putchar
Date: Mon, 15 Feb 2016 09:58:56 +0100 [thread overview]
Message-ID: <56C19350.3010507@redhat.com> (raw)
In-Reply-To: <20160215085406.5u5344qpaoixnjod@hawk.localdomain>
On 15.02.2016 09:54, Andrew Jones wrote:
> On Mon, Feb 15, 2016 at 10:29:54AM +1100, David Gibson wrote:
>> On Sat, Feb 13, 2016 at 05:28:24PM +0100, Andrew Jones wrote:
>>> +bool hcall_have_broken_sc1(void)
>>> +{
>>> + register unsigned long r3 asm("r3") = H_SET_DABR;
>>> + register unsigned long r4 asm("r4") = 0;
>>> +
>>> + asm volatile("sc 1"
>>> + : "=r" (r3)
>>> + : "r" (r3), "r" (r4)
>>> + : "r5", "r6", "r7", "r8", "r9", "r10", "r11", "r12");
>>> +
>>> + return !(r3 == H_SUCCESS || r3 == (unsigned long)H_HARDWARE);
>>
>> It might be safer to explicitly check for H_PRIVILEGE, which is what
>> you'll get in the case of a broken sc 1 under nested virtualization.
>> That way you won't get false positives if H_SET_DABR ever gets any new
>> error codes it can return.
>
> Will do. Thanks. Should we consider a SLOF patch too? (As I stole this
> condition from there, see check_broken_sc1 in lib/libhvcall/brokensc1.c)
Yes, I think it should be fixed there, too.
Thomas
next prev parent reply other threads:[~2016-02-15 8:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 16:28 [kvm-unit-tests PATCH v3 00/17] ppc64: initial drop Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 01/17] arm/arm64: trivial: another assert fix Andrew Jones
2016-02-14 22:55 ` David Gibson
2016-02-15 6:38 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 02/17] Makefile: cscope: also look in arch shared asm Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 03/17] lib: asm-generic: add missing casts Andrew Jones
2016-02-14 22:57 ` David Gibson
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 04/17] devicetree: fix dt_get_memory_params Andrew Jones
2016-02-14 23:00 ` David Gibson
2016-02-15 7:22 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 05/17] arm/arm64: setup improvements Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 06/17] lib: share arm-selftest utility functions Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 07/17] config: no need to mix arch makefiles Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 08/17] powerpc/ppc64: start skeleton framework Andrew Jones
2016-02-15 7:28 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 09/17] powerpc/ppc64: ppc-ify makefiles and linker script Andrew Jones
2016-02-15 7:46 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 10/17] powerpc/ppc64: add a boot rom Andrew Jones
2016-02-15 8:00 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 11/17] powerpc/ppc64: add hcall support and putchar Andrew Jones
2016-02-14 23:29 ` David Gibson
2016-02-15 8:44 ` Thomas Huth
2016-02-15 8:54 ` Andrew Jones
2016-02-15 8:58 ` Thomas Huth [this message]
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 12/17] powerpc/ppc64: adapt arm's setup Andrew Jones
2016-02-15 9:01 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 13/17] powerpc/ppc64: relocate linker VMAs Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 14/17] powerpc/ppc64: add run script and unittests.cfg Andrew Jones
2016-02-15 9:36 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 15/17] mkstandalone: add support for powerpc Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 16/17] powerpc/ppc64: add RTAS support Andrew Jones
2016-02-13 17:18 ` Andrew Jones
2016-02-15 9:59 ` Thomas Huth
2016-02-15 12:00 ` Andrew Jones
2016-02-15 12:15 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 17/17] powerpc/ppc64: make a fake debug-exit Andrew Jones
2016-02-15 10:01 ` Thomas Huth
2016-02-15 10:37 ` [kvm-unit-tests PATCH v3 00/17] ppc64: initial drop Laurent Vivier
2016-02-15 12:08 ` Andrew Jones
2016-02-15 12:12 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C19350.3010507@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).