From: Laurent Vivier <lvivier@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: thuth@redhat.com, dgibson@redhat.com,
david@gibson.dropbear.id.au, agraf@suse.de, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 00/17] ppc64: initial drop
Date: Mon, 15 Feb 2016 11:37:55 +0100 [thread overview]
Message-ID: <56C1AA83.8020200@redhat.com> (raw)
In-Reply-To: <1455380910-30604-1-git-send-email-drjones@redhat.com>
On 13/02/2016 17:28, Andrew Jones wrote:
> This series brings basic setup; starts a test's C entry point, main(),
> and printf, exit, and malloc work. Three more series should follow this
> one which must bring; vector support, mmu support, and smp support, at
> which point I believe the framework could just evolve with the creation
> of unit tests.
>
> Tested on TCG and a P8 kvm_pr machine. I'm looking forward to hearing
> more testing feedback from others. Maybe I should have added an RFT.
>
> v3:
> Paolo's comments:
> - got rid of zero-sized files
>
> Thomas' review comments:
> - remove useless casts in needed cast adding patch
> - got rid of build_romfs building (and committing a binary), just
> offset the rom binary by 256 bytes now
> - added a better error message for a -smp N, N > NR_CPUS user error
> - got rid of infinite loop with broken rtas-poweroff
> - one r-b (wasn't sure the "looks good"'s counted, so didn't add more)
>
> Laurent's testing led me to
> - fix a problem on kvm_pr with broken sc1
> - fix handling of memory regions, expect more than one
> - and a fix to DT code so that works
>
> Additionally:
> - new patches
> - cscope: ppc64 needs to look in lib/powerpc/asm too,
> and arm64 in lib/arm/asm
> - handle memory regions better also for arm
> - a misc trivial fix for arm...
> - align toc to 256 bytes for later gcc
>
> v2:
> Besides rebasing on latest master, v2 addresses all of David's comments
> - assembler cleanup
> - jump into the RTAS blob we get from DT, instead of reproducing it
> - don't store the RTAS root node, always hunt it down
>
> We still haven't addressed debug-exit. Plugging chr-testdev into an spapr
> vty is probably what we should investigate first (as was suggested by Alex
> Graf under the v1 review). For now we keep the hack from v1, but simplified.
>
> Patches also available here
> https://github.com/rhdrjones/kvm-unit-tests/commits/ppc64/initial-drop-v3
>
>
> Andrew Jones (17):
> arm/arm64: trivial: another assert fix
> Makefile: cscope: also look in arch shared asm
> lib: asm-generic: add missing casts
> devicetree: fix dt_get_memory_params
> arm/arm64: setup improvements
> lib: share arm-selftest utility functions
> config: no need to mix arch makefiles
> powerpc/ppc64: start skeleton framework
> powerpc/ppc64: ppc-ify makefiles and linker script
> powerpc/ppc64: add a boot rom
> powerpc/ppc64: add hcall support and putchar
> powerpc/ppc64: adapt arm's setup
> powerpc/ppc64: relocate linker VMAs
> powerpc/ppc64: add run script and unittests.cfg
> mkstandalone: add support for powerpc
> powerpc/ppc64: add RTAS support
> powerpc/ppc64: make a fake debug-exit
>
> Makefile | 8 +-
> README | 3 +-
> arm/Makefile | 1 +
> config/config-arm.mak => arm/Makefile.arm | 2 +-
> config/config-arm64.mak => arm/Makefile.arm64 | 2 +-
> .../config-arm-common.mak => arm/Makefile.common | 3 +-
> arm/selftest.c | 45 +++----
> configure | 6 +
> lib/arm/asm/setup.h | 9 ++
> lib/arm/io.c | 3 +-
> lib/arm/setup.c | 66 +++++++---
> lib/asm-generic/io.h | 12 +-
> lib/devicetree.c | 8 +-
> lib/libcflat.h | 11 +-
> lib/powerpc/.gitignore | 1 +
> lib/powerpc/asm/hcall.h | 43 +++++++
> lib/powerpc/asm/rtas.h | 26 ++++
> lib/powerpc/asm/setup.h | 36 ++++++
> lib/powerpc/hcall.c | 79 ++++++++++++
> lib/powerpc/io.c | 37 ++++++
> lib/powerpc/rtas.c | 139 +++++++++++++++++++++
> lib/powerpc/setup.c | 119 ++++++++++++++++++
> lib/ppc64/.gitignore | 1 +
> lib/ppc64/asm-offsets.c | 12 ++
> lib/ppc64/asm/asm-offsets.h | 1 +
> lib/ppc64/asm/hcall.h | 1 +
> lib/ppc64/asm/io.h | 5 +
> lib/ppc64/asm/page.h | 1 +
> lib/ppc64/asm/rtas.h | 1 +
> lib/ppc64/asm/setup.h | 1 +
> lib/ppc64/asm/spinlock.h | 11 ++
> lib/ppc64/spinlock.c | 11 ++
> lib/report.c | 16 +++
> lib/util.c | 18 +++
> lib/util.h | 23 ++++
> powerpc/Makefile | 1 +
> powerpc/Makefile.common | 71 +++++++++++
> powerpc/Makefile.ppc64 | 20 +++
> powerpc/boot_rom.S | 5 +
> powerpc/cstart64.S | 83 ++++++++++++
> powerpc/flat.lds | 44 +++++++
> powerpc/reloc64.c | 55 ++++++++
> powerpc/run | 55 ++++++++
> powerpc/selftest.c | 64 ++++++++++
> powerpc/unittests.cfg | 30 +++++
> {config => scripts}/asm-offsets.mak | 0
> scripts/mkstandalone.sh | 5 +
> x86/Makefile | 1 +
> .../config-x86-common.mak => x86/Makefile.common | 0
> config/config-i386.mak => x86/Makefile.i386 | 2 +-
> config/config-x86_64.mak => x86/Makefile.x86_64 | 2 +-
> 51 files changed, 1124 insertions(+), 75 deletions(-)
> create mode 100644 arm/Makefile
> rename config/config-arm.mak => arm/Makefile.arm (90%)
> rename config/config-arm64.mak => arm/Makefile.arm64 (89%)
> rename config/config-arm-common.mak => arm/Makefile.common (96%)
> create mode 100644 lib/powerpc/.gitignore
> create mode 100644 lib/powerpc/asm/hcall.h
> create mode 100644 lib/powerpc/asm/rtas.h
> create mode 100644 lib/powerpc/asm/setup.h
> create mode 100644 lib/powerpc/hcall.c
> create mode 100644 lib/powerpc/io.c
> create mode 100644 lib/powerpc/rtas.c
> create mode 100644 lib/powerpc/setup.c
> create mode 100644 lib/ppc64/.gitignore
> create mode 100644 lib/ppc64/asm-offsets.c
> create mode 100644 lib/ppc64/asm/asm-offsets.h
> create mode 100644 lib/ppc64/asm/hcall.h
> create mode 100644 lib/ppc64/asm/io.h
> create mode 100644 lib/ppc64/asm/page.h
> create mode 100644 lib/ppc64/asm/rtas.h
> create mode 100644 lib/ppc64/asm/setup.h
> create mode 100644 lib/ppc64/asm/spinlock.h
> create mode 100644 lib/ppc64/spinlock.c
> create mode 100644 lib/util.c
> create mode 100644 lib/util.h
> create mode 100644 powerpc/Makefile
> create mode 100644 powerpc/Makefile.common
> create mode 100644 powerpc/Makefile.ppc64
> create mode 100644 powerpc/boot_rom.S
> create mode 100644 powerpc/cstart64.S
> create mode 100644 powerpc/flat.lds
> create mode 100644 powerpc/reloc64.c
> create mode 100755 powerpc/run
> create mode 100644 powerpc/selftest.c
> create mode 100644 powerpc/unittests.cfg
> rename {config => scripts}/asm-offsets.mak (100%)
> create mode 100644 x86/Makefile
> rename config/config-x86-common.mak => x86/Makefile.common (100%)
> rename config/config-i386.mak => x86/Makefile.i386 (91%)
> rename config/config-x86_64.mak => x86/Makefile.x86_64 (93%)
>
Tested-by: Laurent Vivier <lvivier@redhat.com>
tested with kvm_pr and kvm_hv.
Just a note for the next release:
$ ./run_tests.sh
./run_tests.sh: line 51: test.log: Permission denied
scripts/runtime.bash: line 48: test.log: Permission denied
PASS selftest-setup
You should check current user can write into test.log.
Laurent
next prev parent reply other threads:[~2016-02-15 10:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 16:28 [kvm-unit-tests PATCH v3 00/17] ppc64: initial drop Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 01/17] arm/arm64: trivial: another assert fix Andrew Jones
2016-02-14 22:55 ` David Gibson
2016-02-15 6:38 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 02/17] Makefile: cscope: also look in arch shared asm Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 03/17] lib: asm-generic: add missing casts Andrew Jones
2016-02-14 22:57 ` David Gibson
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 04/17] devicetree: fix dt_get_memory_params Andrew Jones
2016-02-14 23:00 ` David Gibson
2016-02-15 7:22 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 05/17] arm/arm64: setup improvements Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 06/17] lib: share arm-selftest utility functions Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 07/17] config: no need to mix arch makefiles Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 08/17] powerpc/ppc64: start skeleton framework Andrew Jones
2016-02-15 7:28 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 09/17] powerpc/ppc64: ppc-ify makefiles and linker script Andrew Jones
2016-02-15 7:46 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 10/17] powerpc/ppc64: add a boot rom Andrew Jones
2016-02-15 8:00 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 11/17] powerpc/ppc64: add hcall support and putchar Andrew Jones
2016-02-14 23:29 ` David Gibson
2016-02-15 8:44 ` Thomas Huth
2016-02-15 8:54 ` Andrew Jones
2016-02-15 8:58 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 12/17] powerpc/ppc64: adapt arm's setup Andrew Jones
2016-02-15 9:01 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 13/17] powerpc/ppc64: relocate linker VMAs Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 14/17] powerpc/ppc64: add run script and unittests.cfg Andrew Jones
2016-02-15 9:36 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 15/17] mkstandalone: add support for powerpc Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 16/17] powerpc/ppc64: add RTAS support Andrew Jones
2016-02-13 17:18 ` Andrew Jones
2016-02-15 9:59 ` Thomas Huth
2016-02-15 12:00 ` Andrew Jones
2016-02-15 12:15 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 17/17] powerpc/ppc64: make a fake debug-exit Andrew Jones
2016-02-15 10:01 ` Thomas Huth
2016-02-15 10:37 ` Laurent Vivier [this message]
2016-02-15 12:08 ` [kvm-unit-tests PATCH v3 00/17] ppc64: initial drop Andrew Jones
2016-02-15 12:12 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C1AA83.8020200@redhat.com \
--to=lvivier@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).