From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, dgibson@redhat.com,
david@gibson.dropbear.id.au, agraf@suse.de, lvivier@redhat.com,
pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 16/17] powerpc/ppc64: add RTAS support
Date: Mon, 15 Feb 2016 13:15:33 +0100 [thread overview]
Message-ID: <56C1C165.7070303@redhat.com> (raw)
In-Reply-To: <20160215120034.bvqmblgl7tphkxvx@hawk.localdomain>
On 15.02.2016 13:00, Andrew Jones wrote:
> On Mon, Feb 15, 2016 at 10:59:31AM +0100, Thomas Huth wrote:
>> On 13.02.2016 17:28, Andrew Jones wrote:
>>> Add enough RTAS support to start adding RTAS commands. Just add
>>> power-off for now.
>>>
>>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>>> ---
>>> lib/powerpc/asm/rtas.h | 26 +++++++++
>>> lib/powerpc/io.c | 2 +
>>> lib/powerpc/rtas.c | 139 ++++++++++++++++++++++++++++++++++++++++++++++++
>>> lib/ppc64/asm/rtas.h | 1 +
>>> powerpc/Makefile.common | 1 +
>>> 5 files changed, 169 insertions(+)
>>> create mode 100644 lib/powerpc/asm/rtas.h
>>> create mode 100644 lib/powerpc/rtas.c
>>> create mode 100644 lib/ppc64/asm/rtas.h
>> ...
>>> diff --git a/lib/powerpc/rtas.c b/lib/powerpc/rtas.c
>>> new file mode 100644
>>> index 0000000000000..b6ae7391181f9
>>> --- /dev/null
>>> +++ b/lib/powerpc/rtas.c
>>> @@ -0,0 +1,139 @@
>>> +/*
>>> + * powerpc RTAS
>>> + *
>>> + * Copyright (C) 2016, Red Hat Inc, Andrew Jones <drjones@redhat.com>
>>> + *
>>> + * This work is licensed under the terms of the GNU LGPL, version 2.
>>> + */
>>> +#include <libcflat.h>
>>> +#include <libfdt/libfdt.h>
>>> +#include <devicetree.h>
>>> +#include <asm/spinlock.h>
>>> +#include <asm/hcall.h>
>>> +#include <asm/io.h>
>>> +#include <asm/rtas.h>
>>> +
>>> +#if defined(__powerpc64__)
>>> +struct func_ptr {
>>> + unsigned long ptr;
>>> + unsigned long toc;
>>> +};
>>> +static struct func_ptr rtas_entry_funcptr;
>>> +#endif
>>> +typedef void (*rtas_entry_t)(unsigned long);
>>> +static rtas_entry_t enter_rtas;
>>> +static struct rtas_args rtas_args;
>>> +static struct spinlock lock;
>>
>> I'd maybe name the lock variable "rtas_lock" instead (in case we ever
>> use more locks in this file, it's then more obvious what this lock is
>> about) ... but apart from that, and the bug in the sc1 loop that you
>
> I'll rename lock, and v4 will have the size/4 fix.
>
>> already mentioned, the patch looks fine to me.
>
> Can I add your r-b?
Yes, with the two changes:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2016-02-15 12:15 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 16:28 [kvm-unit-tests PATCH v3 00/17] ppc64: initial drop Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 01/17] arm/arm64: trivial: another assert fix Andrew Jones
2016-02-14 22:55 ` David Gibson
2016-02-15 6:38 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 02/17] Makefile: cscope: also look in arch shared asm Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 03/17] lib: asm-generic: add missing casts Andrew Jones
2016-02-14 22:57 ` David Gibson
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 04/17] devicetree: fix dt_get_memory_params Andrew Jones
2016-02-14 23:00 ` David Gibson
2016-02-15 7:22 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 05/17] arm/arm64: setup improvements Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 06/17] lib: share arm-selftest utility functions Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 07/17] config: no need to mix arch makefiles Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 08/17] powerpc/ppc64: start skeleton framework Andrew Jones
2016-02-15 7:28 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 09/17] powerpc/ppc64: ppc-ify makefiles and linker script Andrew Jones
2016-02-15 7:46 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 10/17] powerpc/ppc64: add a boot rom Andrew Jones
2016-02-15 8:00 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 11/17] powerpc/ppc64: add hcall support and putchar Andrew Jones
2016-02-14 23:29 ` David Gibson
2016-02-15 8:44 ` Thomas Huth
2016-02-15 8:54 ` Andrew Jones
2016-02-15 8:58 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 12/17] powerpc/ppc64: adapt arm's setup Andrew Jones
2016-02-15 9:01 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 13/17] powerpc/ppc64: relocate linker VMAs Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 14/17] powerpc/ppc64: add run script and unittests.cfg Andrew Jones
2016-02-15 9:36 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 15/17] mkstandalone: add support for powerpc Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 16/17] powerpc/ppc64: add RTAS support Andrew Jones
2016-02-13 17:18 ` Andrew Jones
2016-02-15 9:59 ` Thomas Huth
2016-02-15 12:00 ` Andrew Jones
2016-02-15 12:15 ` Thomas Huth [this message]
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 17/17] powerpc/ppc64: make a fake debug-exit Andrew Jones
2016-02-15 10:01 ` Thomas Huth
2016-02-15 10:37 ` [kvm-unit-tests PATCH v3 00/17] ppc64: initial drop Laurent Vivier
2016-02-15 12:08 ` Andrew Jones
2016-02-15 12:12 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C1C165.7070303@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).