From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 08/14] KVM: x86: remove notifiers from PIT discard
 policy
Date: Thu, 18 Feb 2016 19:05:59 +0100
Message-ID: <56C60807.7030104@redhat.com>
References: <1455736496-374-1-git-send-email-rkrcmar@redhat.com>
 <1455736496-374-9-git-send-email-rkrcmar@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, Yuki Shibuya <shibuya.yk@ncos.nec.co.jp>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
	linux-kernel@vger.kernel.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1455736496-374-9-git-send-email-rkrcmar@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 17/02/2016 20:14, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
> Discard policy doesn't rely on information from notifiers, so we don'=
t
> need to register notifiers unconditionally.  We kept correct counts i=
n
> case userspace switched between policies during runtime, but that can=
 be
> avoided by reseting the state.

Ah okay so the WARN_ON could actually be triggered.  But otherwise I
think my suggestion should work.

Paolo