From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PART1 RFC 5/9] svm: Add VMEXIT handlers for AVIC Date: Fri, 19 Feb 2016 12:44:41 +0100 Message-ID: <56C70029.1000406@redhat.com> References: <56C2C1BF.7010700@amd.com> <56C312E1.1080902@redhat.com> <20160216141330.GG10555@potion.brq.redhat.com> <56C354A5.4040807@redhat.com> <20160216180618.GA18952@potion.brq.redhat.com> <56C52B80.5050104@amd.com> <20160218141817.GA6289@potion.brq.redhat.com> <56C5DA62.8080204@redhat.com> <20160218154343.GA18904@potion.brq.redhat.com> <56C5E8E1.9060900@redhat.com> <20160218162701.GB6289@potion.brq.redhat.com> <56C5FCCF.5010802@redhat.com> <56C6FF08.6050408@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: joro@8bytes.org, alex.williamson@redhat.com, gleb@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com, "Wu, Feng" To: Suravee Suthikulpanit , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: Received: from mail-wm0-f46.google.com ([74.125.82.46]:35525 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1427711AbcBSLoo (ORCPT ); Fri, 19 Feb 2016 06:44:44 -0500 In-Reply-To: <56C6FF08.6050408@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 19/02/2016 12:39, Suravee Suthikulpanit wrote: > > Good point. I have made the change by introducing new function pointer, > kvm_x86_ops.vcpu_blocking() and kvm_x86_ops.vcpu_unblocking(). Then > provides the hook to set/unset the IsRunningBit here. Also, I no longer > set the bit in the vcpu_load/vcpu_put. > > If this is okay. I'll send out V2 soon. Great, thanks. Have you tried making the backing page point to the kvm_lapic's regs? If so, I think you're ready to send out v2 indeed. Paolo