From: Paolo Bonzini <pbonzini@redhat.com>
To: Valdis.Kletnieks@vt.edu, Aurelien Jarno <aurelien@aurel32.net>
Cc: Gleb Natapov <gleb@kernel.org>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
Subject: Re: Silence compiler warning in arch/x86/kvm/emulate.c
Date: Fri, 19 Feb 2016 18:56:05 +0100 [thread overview]
Message-ID: <56C75735.3010602@redhat.com> (raw)
In-Reply-To: <10537.1455904440@turing-police.cc.vt.edu>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 19/02/2016 18:54, Valdis.Kletnieks@vt.edu wrote:
> la can get changed here - but there's 2 cases to consider. If it's
> in a 32-bit kernel, anding with -1 is a no-op.
>
> Now if we're on a 64-bit kernel, the 'and' clears the high 32
> bits.
>
> But under what conditions is 'la' a 64-bit quantity that has any
> bits set in the high 32 bits (meaning it's a pointer to something
> over the 4G line) - but it's still valid to smash those bits?
That can happen for example if there is a non-zero segment base. Then
the linear address wraps at 4G.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJWx1cxAAoJEL/70l94x66DFBcIAIkWZ7KaTyh3gfy5Cur7aukA
8NkEKvxZxO46lQAiKxf5ORTdBCdtZDjUjbxTVJoguITK/nnXuBLQIP/aeDhfHdhz
BTYumgH+QV+kmZfn7mwgY5omS05Qx08DmdpQ1jyu1Y1aPVBv6FlsoWcHFrA+oXI2
wtit0OejbPJ9gT4dv1S/etuJvzdINQ/Y4fh/ulkyJJRIw5vvEgW+PN81UNCiSust
w1zkljlfoU4he54IWHa0R1Am/uQBmWRuhvzaMZVKdkGlrN/jJo4ObR5DX+qPujPB
sGSw2HTh8p4IuLwAJ0PvZZPNag+6vdOv9jxJuFpRNQGZLYY5eHL1IFVHaESv0vQ=
=ssTD
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2016-02-19 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 21:49 Silence compiler warning in arch/x86/kvm/emulate.c Valdis Kletnieks
2016-02-19 11:11 ` Aurelien Jarno
2016-02-19 12:05 ` Paolo Bonzini
2016-02-19 17:04 ` Aurelien Jarno
2016-02-19 16:45 ` Aurelien Jarno
2016-02-19 17:54 ` Valdis.Kletnieks
2016-02-19 17:56 ` Paolo Bonzini [this message]
2016-02-20 0:33 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C75735.3010602@redhat.com \
--to=pbonzini@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=aruna.hewapathirane@gmail.com \
--cc=aurelien@aurel32.net \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).