From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: [PATCH v11 20/21] KVM: ARM: Introduce per-vcpu kvm device controls Date: Sat, 20 Feb 2016 21:38:16 +0800 Message-ID: <56C86C48.2060702@linaro.org> References: <1454656456-11640-1-git-send-email-zhaoshenglong@huawei.com> <1454656456-11640-21-git-send-email-zhaoshenglong@huawei.com> <20160208124059.GF620@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, will.deacon@arm.com, wei@redhat.com, cov@codeaurora.org, peter.huangpeng@huawei.com, hangaohuai@huawei.com, Peter Maydell , Paolo Bonzini To: Christoffer Dall , Shannon Zhao Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:34265 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753131AbcBTNi2 (ORCPT ); Sat, 20 Feb 2016 08:38:28 -0500 Received: by mail-pa0-f46.google.com with SMTP id fy10so65651573pac.1 for ; Sat, 20 Feb 2016 05:38:28 -0800 (PST) In-Reply-To: <20160208124059.GF620@cbox> Sender: kvm-owner@vger.kernel.org List-ID: On 2016/2/8 20:40, Christoffer Dall wrote: >> + case KVM_SET_DEVICE_ATTR: { >> >+ if (copy_from_user(&attr, argp, sizeof(attr))) >> >+ return -EFAULT; >> >+ return kvm_arm_vcpu_set_attr(vcpu, &attr); >> >+ } >> >+ case KVM_GET_DEVICE_ATTR: { >> >+ if (copy_from_user(&attr, argp, sizeof(attr))) >> >+ return -EFAULT; >> >+ return kvm_arm_vcpu_get_attr(vcpu, &attr); >> >+ } >> >+ case KVM_HAS_DEVICE_ATTR: { >> >+ if (copy_from_user(&attr, argp, sizeof(attr))) >> >+ return -EFAULT; >> >+ return kvm_arm_vcpu_has_attr(vcpu, &attr); >> >+ } > do we share the ioctl number space across device, VM, and VCPU file > descriptors? Yeah, they're shared across device, VM, and VCPU. Thanks, -- Shannon