From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH v3 05/11] KVM: page track: introduce
 kvm_page_track_{add,remove}_page
Date: Tue, 23 Feb 2016 12:18:42 +0800
Message-ID: <56CBDDA2.3080806@linux.intel.com>
References: <1455449503-20993-1-git-send-email-guangrong.xiao@linux.intel.com>
 <1455449503-20993-6-git-send-email-guangrong.xiao@linux.intel.com>
 <56C6FE97.3080806@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, kai.huang@linux.intel.com,
	jike.song@intel.com
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <56C6FE97.3080806@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 02/19/2016 07:37 PM, Paolo Bonzini wrote:
>
>
> On 14/02/2016 12:31, Xiao Guangrong wrote:
>> +static bool check_mode(enum kvm_page_track_mode mode)
>> +{
>> +	if (mode < 0 || mode >= KVM_PAGE_TRACK_MAX)
>> +		return false;
>> +
>> +	return true;
>> +}
>
> Oops, forgot about this; please rename to page_track_mode_is_valid and
> make it "static inline".

Sure, it looks good to me. :)