From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 00/12] KVM: MMU: cleanup around kvm_sync_page, and a few micro-optimizations Date: Thu, 25 Feb 2016 16:28:42 +0800 Message-ID: <56CEBB3A.1080709@linux.intel.com> References: <1456319873-34182-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: yoshikawa_takuya_b1@lab.ntt.co.jp, mtosatti@redhat.com To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: Received: from mga03.intel.com ([134.134.136.65]:17038 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbcBYI2r (ORCPT ); Thu, 25 Feb 2016 03:28:47 -0500 In-Reply-To: <1456319873-34182-1-git-send-email-pbonzini@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/24/2016 09:17 PM, Paolo Bonzini wrote: > This series started from looking at mmu_unsync_walk for the ubsan thread. > Patches 1 and 2 are the result of the discussions in that thread. > > Patches 3 to 9 do more cleanups in __kvm_sync_page and its callers. > Among other changes, it removes kvm_sync_page_transient and avoids > duplicate code between __kvm_sync_page and kvm_sync_pages. > > I stopped where I had questions about the existing kvm_mmu_get_page > code (see patch 8 for the question). However perhaps more cleanups > are possible, also thanks to Takuya's work on that function and > link_shadow_page. > > Patches 10 to 12 are just micro-optimizations. > > Guangrong, it would be great if you took a look since you know this part > of KVM very well. I have reviewed it and it works fine except the one leaking tlb flush out of mmu-lock. I will continue to simplify the path of walking unsync sp to keep mmu_page_path smaller and make comments for kvm_mmu_get_page on top of this patchset. BTW, is any conflict to apply my page-tracking patchset on top of this patchset (i noticed you've merged this patchset on kvm/queue)? Please tell me to rebase it if it is needed.