From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after
 mmu_sync_children
Date: Thu, 25 Feb 2016 09:49:07 +0100
Message-ID: <56CEC003.1070402@redhat.com>
References: <1456319873-34182-1-git-send-email-pbonzini@redhat.com>
 <1456319873-34182-10-git-send-email-pbonzini@redhat.com>
 <56CE63D1.40009@lab.ntt.co.jp> <56CEAEA7.8080702@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: mtosatti@redhat.com
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <56CEAEA7.8080702@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 25/02/2016 08:35, Xiao Guangrong wrote:
>> This may release the mmu_lock before committing the zapping.
>> Is it safe?  If so, we may want to see the reason in the changelog.
> 
> It is unsafe indeed, please do not do it.

Can you explain why?  kvm_zap_obsolete_pages does the same.

Paolo