From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>,
stable@vger.kernel.org, Nadav Amit <namit@cs.technion.ac.il>,
Andrey Wagin <avagin@gmail.com>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH] KVM: x86: fix root cause for missed hardware breakpoints
Date: Fri, 26 Feb 2016 13:48:47 +0100 [thread overview]
Message-ID: <56D049AF.3070205@redhat.com> (raw)
In-Reply-To: <88D39E57-59DC-4DC6-9C14-2C69D10DF9C8@gmail.com>
On 26/02/2016 13:14, Nadav Amit wrote:
> Seems correct. The code may be easier to follow if the following line:
>
> vcpu->arch.switch_db_regs &= ~KVM_DEBUGREG_WONT_EXIT
>
> would have been moved out of svm_sync_dirty_debug_regs and
> vmx_sync_dirty_debug_regs into the flow of vcpu_enter_guest (above).
It is there because removing the bit is tied to actually enabling debug
register exits. On one hand it's bad to have duplicated code, on the
other hand there's a reason for it... I'm a bit undecided on whether to
move that duplicated line to x86.c.
Paolo
prev parent reply other threads:[~2016-02-26 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 11:46 [PATCH] KVM: x86: fix root cause for missed hardware breakpoints Paolo Bonzini
2016-02-26 12:01 ` Xiao Guangrong
2016-02-26 12:14 ` Nadav Amit
2016-02-26 12:48 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D049AF.3070205@redhat.com \
--to=pbonzini@redhat.com \
--cc=avagin@gmail.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox