kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com
Subject: Re: [kvm-unit-tests PATCH 4/4] x86: fix printf format warnings
Date: Tue, 1 Mar 2016 11:52:04 +0100	[thread overview]
Message-ID: <56D57454.3080504@redhat.com> (raw)
In-Reply-To: <20160301092448.dj42i7cvtmgtpumz@hawk.localdomain>



On 01/03/2016 10:24, Andrew Jones wrote:
>> > So either the lower part has explicitely be casted to (uint32_t), or
>> > simply print the whole value only once with llx, without the colon
>> > inbetween.
> Uff, I guess I was in monkey mode at this point. I'll change it to the
> last suggestion, no ':'.

There are cases where the result is split in two 32-bit values (e.g.
IA32_VMX_PROCBASED_CTLS) so the ":" is nice to have.

Paolo

  reply	other threads:[~2016-03-01 10:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 20:19 [kvm-unit-tests PATCH 0/4] add fmt warnings to printf, and fix bad uses Andrew Jones
2016-02-29 20:19 ` [kvm-unit-tests PATCH 1/4] lib: *printf: warn on format/arg mismatch Andrew Jones
2016-03-01 10:43   ` Paolo Bonzini
2016-03-01 11:01     ` Andrew Jones
2016-02-29 20:19 ` [kvm-unit-tests PATCH 2/4] lib/alloc: fix format warnings, add/use PRIx64 Andrew Jones
2016-03-01  4:58   ` Thomas Huth
2016-03-01  9:15     ` Andrew Jones
2016-03-01 11:04       ` Paolo Bonzini
2016-03-01 12:22         ` Andrew Jones
2016-03-01 10:47   ` Paolo Bonzini
2016-02-29 20:19 ` [kvm-unit-tests PATCH 3/4] arm64: fix printf format warnings Andrew Jones
2016-03-01  5:01   ` Thomas Huth
2016-03-01  9:17     ` Andrew Jones
2016-02-29 20:19 ` [kvm-unit-tests PATCH 4/4] x86: " Andrew Jones
2016-03-01  5:30   ` Thomas Huth
2016-03-01  9:24     ` Andrew Jones
2016-03-01 10:52       ` Paolo Bonzini [this message]
2016-03-01 11:02         ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D57454.3080504@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).