From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests 0/5] Split large EPT mappings properly Date: Tue, 1 Mar 2016 22:13:33 +0100 Message-ID: <56D605FD.5020107@redhat.com> References: <1456860622-31251-1-git-send-email-pfeiner@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Peter Feiner , kvm@vger.kernel.org, jan.kiszka@siemens.com Return-path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:35661 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbcCAVNh (ORCPT ); Tue, 1 Mar 2016 16:13:37 -0500 Received: by mail-wm0-f47.google.com with SMTP id l68so56835098wml.0 for ; Tue, 01 Mar 2016 13:13:36 -0800 (PST) In-Reply-To: <1456860622-31251-1-git-send-email-pfeiner@google.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/03/2016 20:30, Peter Feiner wrote: > install_ept_entry would overwrite arbitrary memory when it encountered > a large page. > > I discovered the bug while working on a simple multi-page allocator, > which I'm using for huge page testing, that sorts the free list in > ascending order of HPA. > > Peter Feiner (5): > x86: vmx.h: trivial whitespace fixes > x86: vmx: Named constant: EPT_ADDR_MASK > x86: vmx: Named constant: EPT_LEVEL_SHIFT > x86: vmx: split large EPTEs in install_ept_entry > x86: vmx: don't explicitly split identity EPT map > > x86/vmx.c | 65 +++++++++++++++++++++++++++++++++++++++++++-------------- > x86/vmx.h | 9 +++++--- > x86/vmx_tests.c | 7 ------- > 3 files changed, 55 insertions(+), 26 deletions(-) Looks good apart for not reusing PAGE_MASK in patch 2. Thanks! Paolo