From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH 8/9] nvdimm acpi: emulate dsm method
Date: Wed, 2 Mar 2016 15:21:04 +0800
Message-ID: <56D69460.30402@linux.intel.com>
References: <1456829771-71553-1-git-send-email-guangrong.xiao@linux.intel.com>
 <1456829771-71553-9-git-send-email-guangrong.xiao@linux.intel.com>
 <20160301190240-mutt-send-email-mst@redhat.com>
 <56D65E42.1050108@linux.intel.com>
 <20160302081841-mutt-send-email-mst@redhat.com>
 <56D69307.6040902@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org,
	mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net,
	ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org,
	qemu-devel@nongnu.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga01.intel.com ([192.55.52.88]:13126 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750875AbcCBHVT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 2 Mar 2016 02:21:19 -0500
In-Reply-To: <56D69307.6040902@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 03/02/2016 03:15 PM, Xiao Guangrong wrote:

>>>>> +    in = g_malloc(TARGET_PAGE_SIZE);
>>
>> ugh. manual memory management :(
>>
>
> Hmm... Or use GArray? But it is :)

Sorry, typo.

But it is the static size and we should read all memory out to get
the consistent data to avid guest changes it at anytime. It is no
much room to improve it i think...