From: Laurent Vivier <lvivier@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com
Cc: dgibson@redhat.com
Subject: Re: [PATCH v3] powerpc: Add tests for sPAPR h-calls
Date: Wed, 2 Mar 2016 11:33:19 +0100 [thread overview]
Message-ID: <56D6C16F.7060407@redhat.com> (raw)
In-Reply-To: <56D6BEDE.7030403@redhat.com>
On 02/03/2016 11:22, Paolo Bonzini wrote:
>
>
> On 02/03/2016 11:07, Laurent Vivier wrote:
>>>> + report_xfail("h-call available", rc == H_FUNCTION, rc == H_SUCCESS);
>>>> + if (rc != H_SUCCESS)
>>>> + return;
>> I think it can be disturbing to not always have the same number of
>> tests, so remove the initial checking and use the report_xfail on the
>> following report.
>>
>>
>
> It's actually fairly common, see for example x86/apic and x86/xsave tests.
OK, so you can add my
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
to this patch (the other comment about asm() doesn't worth a re-spin)
Laurent
next prev parent reply other threads:[~2016-03-02 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 8:40 [PATCH v3] powerpc: Add tests for sPAPR h-calls Thomas Huth
2016-03-02 10:07 ` Laurent Vivier
2016-03-02 10:22 ` Paolo Bonzini
2016-03-02 10:33 ` Laurent Vivier [this message]
2016-03-02 10:56 ` Thomas Huth
2016-03-02 11:37 ` Paolo Bonzini
2016-03-02 23:23 ` David Gibson
2016-03-03 8:58 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D6C16F.7060407@redhat.com \
--to=lvivier@redhat.com \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox