From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com
Cc: dgibson@redhat.com
Subject: Re: [PATCH v3] powerpc: Add tests for sPAPR h-calls
Date: Wed, 2 Mar 2016 12:37:59 +0100 [thread overview]
Message-ID: <56D6D097.5010109@redhat.com> (raw)
In-Reply-To: <56D6C6C2.3000207@redhat.com>
On 02/03/2016 11:56, Thomas Huth wrote:
> > > +
> > > + asm volatile (" sc 1 " : "+r"(r3), "=r"(r4) : "r"(r3));
> >
> > as you use "+r" with r3 in the output operands field, I think you don't
> > have to declare it in the input operands field.
>
> Ah, ok, ... gcc inline assembly is always confusing...
> Paolo, Andrew, shall I sent a new version for fixing this nit, or is it
> ok to keep it in the current, slightly redundant shape?
I guess the current one is fine because of the asm register in the
declarations.
The "really correct" one would use "=r" in the r3 output and "0" in the
r3 input, I think.
Paolo
next prev parent reply other threads:[~2016-03-02 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 8:40 [PATCH v3] powerpc: Add tests for sPAPR h-calls Thomas Huth
2016-03-02 10:07 ` Laurent Vivier
2016-03-02 10:22 ` Paolo Bonzini
2016-03-02 10:33 ` Laurent Vivier
2016-03-02 10:56 ` Thomas Huth
2016-03-02 11:37 ` Paolo Bonzini [this message]
2016-03-02 23:23 ` David Gibson
2016-03-03 8:58 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D6D097.5010109@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox