From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [PATCH v3] powerpc: Add tests for sPAPR h-calls Date: Thu, 3 Mar 2016 09:58:13 +0100 Message-ID: <56D7FCA5.2050100@redhat.com> References: <1456908043-11184-1-git-send-email-thuth@redhat.com> <56D6BB7B.70401@redhat.com> <20160303102332.66345df6@voom.fritz.box> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Nqpa0IP72x3gDbkutevELit2fpU42eCa1" Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com To: David Gibson , Laurent Vivier Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35149 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756681AbcCCI6X (ORCPT ); Thu, 3 Mar 2016 03:58:23 -0500 In-Reply-To: <20160303102332.66345df6@voom.fritz.box> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Nqpa0IP72x3gDbkutevELit2fpU42eCa1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03.03.2016 00:23, David Gibson wrote: > On Wed, 2 Mar 2016 11:07:55 +0100 > Laurent Vivier wrote: >=20 >> On 02/03/2016 09:40, Thomas Huth wrote: >>> Introduce a test for sPAPR hypercalls, starting with the >>> three hypercalls H_SET_SPRG0, H_PAGE_INIT and H_RANDOM. >>> >>> Signed-off-by: Thomas Huth >>> --- =2E.. >>> +static int h_random(uint64_t *val) >>> +{ >>> + register uint64_t r3 asm("r3") =3D H_RANDOM; >>> + register uint64_t r4 asm("r4"); >>> + >>> + asm volatile (" sc 1 " : "+r"(r3), "=3Dr"(r4) : "r"(r3)); =20 >> >> as you use "+r" with r3 in the output operands field, I think you don'= t >> have to declare it in the input operands field. >=20 > More importantly, I think a hypercall is allowed to clobber any of the > volatile registers (r0 & r3..r12), so they probably need to be declared= > in the clobbers as well. Ok, that's a point ... I'll fix it up and send a v4. Thomas --Nqpa0IP72x3gDbkutevELit2fpU42eCa1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJW1/yrAAoJEC7Z13T+cC21l/oQAISLWpClLukbI/Ok1aT+rjCq /6tDD/YZMAtPg06OL458yGKfYqjFxB7QSlgT3hLBsLuritMp+od1QTPTEI/bNex7 u+Qed7DPbvC5cFqUHbnx7t1nkA7EBf4ZEfM5yTB6Yl5t0QtpPEA7BAHkgN7Cx07n T9Qn2/OXPppC6P+iKK1tyJVYQcFoFGHC8WqhPj70CwEhYSHwbQB+PN/N7OW1cDJb V4XqgljsiYegrQEmd5fr/+ArWDK5bLoZkYV5owB6kwP4+wIS0YuMM08OApxkvfxI OR2+qdJLnldJQYQ0prr0NC6jDrTgq3WnYlEoVHaEzqvbzF9cNryALr3JNlGhLlsJ G1P/LfnO2cy7NamFRAn0GL+VRfBSkRR7wm0zNxVvWOAvyLYJBSlK/5JqNotWkeXb sIFrp5ATg5lFKQPL2OO1Aa99kYu9yFzJL8+PDP5v/axYPC28X7mu7gsLG3/Bbixc zCULNSDN13+rHWrqKHSJJOqf5f+Df6R5Prk9MiB70oiox9dtdw/dwigjw9jqjtO3 eBWJoCftDVE/TIh1QrMqDm/DOU5amcMDV0wvnpoDdDL7SUyz0QuCmlkDOAtpNVsH T4aXYV6VOTEdN0bhUhkX2cOS8cJe1mqFDzpDu6eIufshHBqzB2+VvvlYcmwmhRrf mFb6Kt0BTi+h4RFMxJ+g =fBvC -----END PGP SIGNATURE----- --Nqpa0IP72x3gDbkutevELit2fpU42eCa1--