From: Andre Przywara <andre.przywara@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 3/4] pre_init: add support for i386 also
Date: Thu, 3 Mar 2016 10:53:09 +0000 [thread overview]
Message-ID: <56D81795.5000805@arm.com> (raw)
In-Reply-To: <20160302025646.GA7637@arm.com>
Hi Will,
On 02/03/16 02:57, Will Deacon wrote:
> On Wed, Feb 24, 2016 at 03:33:07PM +0000, Andre Przywara wrote:
>> Currently the pre_init support is provided only for x86_64. Since
>> having 32-bit x86 supported as well is not far off, just add an
>> implementation using i386 assembly instructions and the respective
>> syscall ABI.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>> ---
>> Makefile | 1 +
>> x86/init32.S | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 51 insertions(+)
>> create mode 100644 x86/init32.S
>
> Did you manage to test this?
Yes, I think I tested it back when I originally wrote this, but I just
redid the testing using a 32-bit Ubuntu-Core i386 chroot (and deleting
the .lkvm/default directory before testing to make sure you don't get an
older version of init).
It works fine and apart from the size of the binary I can't tell a
difference between booting with or without the patch.
Cheers,
Andre.
next prev parent reply other threads:[~2016-03-03 10:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 15:33 [PATCH 0/4] kvmtool: add PRE_INIT support for ARM/ARM64 Andre Przywara
2016-02-24 15:33 ` [PATCH 1/4] pre_init: rename x86/init.S to x86/init64.S Andre Przywara
2016-02-24 15:33 ` [PATCH 2/4] pre_init: x86/init64.S: use defines for syscall numbers Andre Przywara
2016-02-24 15:33 ` [PATCH 3/4] pre_init: add support for i386 also Andre Przywara
2016-03-02 2:57 ` Will Deacon
2016-03-03 10:53 ` Andre Przywara [this message]
2016-02-24 15:33 ` [PATCH 4/4] pre_init: add ARM implementations Andre Przywara
2016-03-02 3:00 ` Will Deacon
2016-03-02 23:38 ` André Przywara
2016-03-03 21:08 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D81795.5000805@arm.com \
--to=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=oleg@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).