From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH] powerpc: Add tests for RTAS Date: Thu, 3 Mar 2016 18:12:06 +0100 Message-ID: <56D87066.1090205@redhat.com> References: <1457008099-29944-1-git-send-email-lvivier@redhat.com> <20160303160309.GC2354@potion.brq.redhat.com> <56D8666A.40508@redhat.com> <20160303170912.GD2354@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Laurent Vivier , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com, thuth@redhat.com, dgibson@redhat.com To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32946 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923AbcCCRML (ORCPT ); Thu, 3 Mar 2016 12:12:11 -0500 In-Reply-To: <20160303170912.GD2354@potion.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/03/2016 18:09, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >>>>> >>> > + /* compute epoch: substract DAYS(since_March(1-1-1970)) *= / >>>>> >>> > + epoch =3D DAYS(year, month, day) - DAYS(1969, 11, 1); > And this comment points out that the API is bad. :) >=20 > (Btw. am I going overboard?) Only because I've committed it already. ;) Paolo