From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH kvm-unit-tests] build: enable -Werror Date: Fri, 4 Mar 2016 09:49:56 +0100 Message-ID: <56D94C34.7010807@redhat.com> References: <1457042122-30727-1-git-send-email-pfeiner@google.com> <56D94BB9.3030705@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Thomas Huth , Peter Feiner , kvm@vger.kernel.org, drjones@redhat.com Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:36779 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755178AbcCDIt7 (ORCPT ); Fri, 4 Mar 2016 03:49:59 -0500 Received: by mail-wm0-f68.google.com with SMTP id l68so3032251wml.3 for ; Fri, 04 Mar 2016 00:49:58 -0800 (PST) In-Reply-To: <56D94BB9.3030705@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/03/2016 09:47, Thomas Huth wrote: >> > asm volatile("mov %%dr7,%0" : "=r" (dr7)); >> > debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR); >> > /* Commented out: KVM does not support DEBUGCTL so far */ >> > + assert(debugctl == debugctl); >> > report("Guest=host debug controls", dr7 == 0x402 /* && debugctl == 0x1 */); > Now these assert()s are really ugly. Wouldn't it be better do comment > out the "debugctl = rdmsr(MSR_IA32_DEBUGCTLMSR);" line instead? This also looks better than the asserts: (void)debugctl; Thomas, if you're okay with it I can do the change locally. Paolo