From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v5 2/5] nvdimm acpi: introduce patched dsm memory Date: Fri, 4 Mar 2016 23:32:36 +0800 Message-ID: <56D9AA94.5000308@linux.intel.com> References: <1456919441-101204-1-git-send-email-guangrong.xiao@linux.intel.com> <1456919441-101204-3-git-send-email-guangrong.xiao@linux.intel.com> <20160303151206-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: "Michael S. Tsirkin" Return-path: Received: from mga14.intel.com ([192.55.52.115]:4297 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758892AbcCDPeM (ORCPT ); Fri, 4 Mar 2016 10:34:12 -0500 In-Reply-To: <20160303151206-mutt-send-email-mst@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/03/2016 09:12 PM, Michael S. Tsirkin wrote: >> /* copy AML table into ACPI tables blob and patch header there */ >> g_array_append_vals(table_data, ssdt->buf->data, ssdt->buf->len); >> + mem_addr_offset = build_append_named_dword(table_data, >> + NVDIMM_ACPI_MEM_ADDR); >> + >> + bios_linker_loader_alloc(linker, NVDIMM_DSM_MEM_FILE, TARGET_PAGE_SIZE, >> + false /* high memory */); >> + bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE, >> + NVDIMM_DSM_MEM_FILE, table_data, >> + table_data->data + mem_addr_offset, >> + sizeof(uint32_t)); >> build_header(linker, table_data, >> - (void *)(table_data->data + table_data->len - ssdt->buf->len), >> - "SSDT", ssdt->buf->len, 1, NULL, "NVDIMM"); >> + (void *)(table_data->data + nvdimm_ssdt), >> + "SSDT", table_data->len - nvdimm_ssdt, 1, NULL, "NVDIMM"); >> free_aml_allocator(); > > I prefer ssdt->buf->len to table_data->len - nvdimm_ssdt. > Pls fix by a follow-up patch unless there is a respin. Ah, we can not do that as the NVDIMM_ACPI_MEM_ADDR is appended in the table which is not taken into account in ssdt. Sorry, i just spotted it when i was addressing all your comments in the new version. :(