From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests] arm: fix parallel build (make -j) Date: Fri, 4 Mar 2016 16:45:09 +0100 Message-ID: <56D9AD85.7050904@redhat.com> References: <1457041274-32283-1-git-send-email-pfeiner@google.com> <20160304110458.GA3641@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Andrew Jones , Peter Feiner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49667 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbcCDPpN (ORCPT ); Fri, 4 Mar 2016 10:45:13 -0500 In-Reply-To: <20160304110458.GA3641@localhost.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/03/2016 12:04, Andrew Jones wrote: >> > + >> > +$(TEST_DIR)/selftest.o $(TEST_DIR)/spinlock-test.o $(cstart.o): $(asm-offsets) > You know a project is really growing when you need 'make -j' :-) > > How about this patch instead though > > -test_cases: $(generated_files) $(tests-common) $(tests) > +test_cases: $(tests-common) $(tests) > +$(patsubst %.flat,%.o,$(tests-common) $(tests)) $(cstart.o): $(generated_files) > > Or, hmm, actually any $(TEST_DIR)/ lib/$(TEST_DIR)/ or lib/$(ARCH)/ > source file could depend on asm-offsets. So the above probably isn't > sufficient for the long term either. I expect a relatively small part of the .o files to need asm-offsets, so I'm going with Peter's patch. Paolo