* [kvm-unit-tests] arm: fix parallel build (make -j)
@ 2016-03-03 21:41 Peter Feiner
2016-03-04 11:04 ` Andrew Jones
2016-03-04 17:04 ` [PATCH kvm-unit-tests v2] " Peter Feiner
0 siblings, 2 replies; 7+ messages in thread
From: Peter Feiner @ 2016-03-03 21:41 UTC (permalink / raw)
To: kvm, drjones, pbonzini; +Cc: pfeiner
Dependency on asm-offsets.h wasn't made explicit in the Makefiles.
Worked without -j because non-parallel make builds dependencies in
declared order.
Signed-off-by: Peter Feiner <pfeiner@google.com>
---
arm/Makefile.common | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arm/Makefile.common b/arm/Makefile.common
index dd3a0ca..6de82cf 100644
--- a/arm/Makefile.common
+++ b/arm/Makefile.common
@@ -71,3 +71,5 @@ test_cases: $(generated_files) $(tests-common) $(tests)
$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
+
+$(TEST_DIR)/selftest.o $(TEST_DIR)/spinlock-test.o $(cstart.o): $(asm-offsets)
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [kvm-unit-tests] arm: fix parallel build (make -j)
2016-03-03 21:41 [kvm-unit-tests] arm: fix parallel build (make -j) Peter Feiner
@ 2016-03-04 11:04 ` Andrew Jones
2016-03-04 15:45 ` Paolo Bonzini
2016-03-04 17:04 ` [PATCH kvm-unit-tests v2] " Peter Feiner
1 sibling, 1 reply; 7+ messages in thread
From: Andrew Jones @ 2016-03-04 11:04 UTC (permalink / raw)
To: Peter Feiner; +Cc: kvm, pbonzini
On Thu, Mar 03, 2016 at 01:41:14PM -0800, Peter Feiner wrote:
> Dependency on asm-offsets.h wasn't made explicit in the Makefiles.
> Worked without -j because non-parallel make builds dependencies in
> declared order.
>
> Signed-off-by: Peter Feiner <pfeiner@google.com>
> ---
> arm/Makefile.common | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arm/Makefile.common b/arm/Makefile.common
> index dd3a0ca..6de82cf 100644
> --- a/arm/Makefile.common
> +++ b/arm/Makefile.common
> @@ -71,3 +71,5 @@ test_cases: $(generated_files) $(tests-common) $(tests)
>
> $(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
> $(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
> +
> +$(TEST_DIR)/selftest.o $(TEST_DIR)/spinlock-test.o $(cstart.o): $(asm-offsets)
You know a project is really growing when you need 'make -j' :-)
How about this patch instead though
-test_cases: $(generated_files) $(tests-common) $(tests)
+test_cases: $(tests-common) $(tests)
+$(patsubst %.flat,%.o,$(tests-common) $(tests)) $(cstart.o): $(generated_files)
Or, hmm, actually any $(TEST_DIR)/ lib/$(TEST_DIR)/ or lib/$(ARCH)/
source file could depend on asm-offsets. So the above probably isn't
sufficient for the long term either.
Thanks,
drew
> --
> 2.7.0.rc3.207.g0ac5344
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [kvm-unit-tests] arm: fix parallel build (make -j)
2016-03-04 11:04 ` Andrew Jones
@ 2016-03-04 15:45 ` Paolo Bonzini
2016-03-04 16:28 ` Andrew Jones
0 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2016-03-04 15:45 UTC (permalink / raw)
To: Andrew Jones, Peter Feiner; +Cc: kvm
On 04/03/2016 12:04, Andrew Jones wrote:
>> > +
>> > +$(TEST_DIR)/selftest.o $(TEST_DIR)/spinlock-test.o $(cstart.o): $(asm-offsets)
> You know a project is really growing when you need 'make -j' :-)
>
> How about this patch instead though
>
> -test_cases: $(generated_files) $(tests-common) $(tests)
> +test_cases: $(tests-common) $(tests)
> +$(patsubst %.flat,%.o,$(tests-common) $(tests)) $(cstart.o): $(generated_files)
>
> Or, hmm, actually any $(TEST_DIR)/ lib/$(TEST_DIR)/ or lib/$(ARCH)/
> source file could depend on asm-offsets. So the above probably isn't
> sufficient for the long term either.
I expect a relatively small part of the .o files to need asm-offsets, so
I'm going with Peter's patch.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [kvm-unit-tests] arm: fix parallel build (make -j)
2016-03-04 15:45 ` Paolo Bonzini
@ 2016-03-04 16:28 ` Andrew Jones
2016-03-04 17:03 ` Peter Feiner
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Jones @ 2016-03-04 16:28 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Peter Feiner, kvm
On Fri, Mar 04, 2016 at 04:45:09PM +0100, Paolo Bonzini wrote:
>
>
> On 04/03/2016 12:04, Andrew Jones wrote:
> >> > +
> >> > +$(TEST_DIR)/selftest.o $(TEST_DIR)/spinlock-test.o $(cstart.o): $(asm-offsets)
> > You know a project is really growing when you need 'make -j' :-)
> >
> > How about this patch instead though
> >
> > -test_cases: $(generated_files) $(tests-common) $(tests)
> > +test_cases: $(tests-common) $(tests)
> > +$(patsubst %.flat,%.o,$(tests-common) $(tests)) $(cstart.o): $(generated_files)
> >
> > Or, hmm, actually any $(TEST_DIR)/ lib/$(TEST_DIR)/ or lib/$(ARCH)/
> > source file could depend on asm-offsets. So the above probably isn't
> > sufficient for the long term either.
>
> I expect a relatively small part of the .o files to need asm-offsets, so
> I'm going with Peter's patch.
Well, his patch adds the dependency for $(TEST_DIR)/spinlock-test.o,
which actually doesn't need it. We should either just put the ones
that need it, or all of them.
Thanks,
drew
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [kvm-unit-tests] arm: fix parallel build (make -j)
2016-03-04 16:28 ` Andrew Jones
@ 2016-03-04 17:03 ` Peter Feiner
0 siblings, 0 replies; 7+ messages in thread
From: Peter Feiner @ 2016-03-04 17:03 UTC (permalink / raw)
To: Andrew Jones; +Cc: Paolo Bonzini, kvm
On Fri, Mar 4, 2016 at 8:28 AM, Andrew Jones <drjones@redhat.com> wrote:
> On Fri, Mar 04, 2016 at 04:45:09PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 04/03/2016 12:04, Andrew Jones wrote:
>> >> > +
>> >> > +$(TEST_DIR)/selftest.o $(TEST_DIR)/spinlock-test.o $(cstart.o): $(asm-offsets)
>> > You know a project is really growing when you need 'make -j' :-)
>> >
>> > How about this patch instead though
>> >
>> > -test_cases: $(generated_files) $(tests-common) $(tests)
>> > +test_cases: $(tests-common) $(tests)
>> > +$(patsubst %.flat,%.o,$(tests-common) $(tests)) $(cstart.o): $(generated_files)
>> >
>> > Or, hmm, actually any $(TEST_DIR)/ lib/$(TEST_DIR)/ or lib/$(ARCH)/
>> > source file could depend on asm-offsets. So the above probably isn't
>> > sufficient for the long term either.
>>
>> I expect a relatively small part of the .o files to need asm-offsets, so
>> I'm going with Peter's patch.
>
> Well, his patch adds the dependency for $(TEST_DIR)/spinlock-test.o,
> which actually doesn't need it. We should either just put the ones
> that need it, or all of them.
My mistake! Evidently I can't read the output of grep properly. I'll
send v2 with the minimal list of dependencies.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH kvm-unit-tests v2] arm: fix parallel build (make -j)
2016-03-03 21:41 [kvm-unit-tests] arm: fix parallel build (make -j) Peter Feiner
2016-03-04 11:04 ` Andrew Jones
@ 2016-03-04 17:04 ` Peter Feiner
2016-03-04 18:34 ` Andrew Jones
1 sibling, 1 reply; 7+ messages in thread
From: Peter Feiner @ 2016-03-04 17:04 UTC (permalink / raw)
To: kvm, drjones, pbonzini; +Cc: pfeiner
Dependency on asm-offsets.h wasn't made explicit in the Makefiles.
Worked without -j because non-parallel make builds dependencies in
declared order.
Signed-off-by: Peter Feiner <pfeiner@google.com>
---
v2:
* Removed unnecessary dependency from spinlock-test.o
arm/Makefile.common | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arm/Makefile.common b/arm/Makefile.common
index dd3a0ca..9a2d61f 100644
--- a/arm/Makefile.common
+++ b/arm/Makefile.common
@@ -71,3 +71,5 @@ test_cases: $(generated_files) $(tests-common) $(tests)
$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
+
+$(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH kvm-unit-tests v2] arm: fix parallel build (make -j)
2016-03-04 17:04 ` [PATCH kvm-unit-tests v2] " Peter Feiner
@ 2016-03-04 18:34 ` Andrew Jones
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Jones @ 2016-03-04 18:34 UTC (permalink / raw)
To: Peter Feiner; +Cc: kvm, pbonzini
On Fri, Mar 04, 2016 at 09:04:47AM -0800, Peter Feiner wrote:
> Dependency on asm-offsets.h wasn't made explicit in the Makefiles.
> Worked without -j because non-parallel make builds dependencies in
> declared order.
>
> Signed-off-by: Peter Feiner <pfeiner@google.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
> ---
>
> v2:
> * Removed unnecessary dependency from spinlock-test.o
>
>
> arm/Makefile.common | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arm/Makefile.common b/arm/Makefile.common
> index dd3a0ca..9a2d61f 100644
> --- a/arm/Makefile.common
> +++ b/arm/Makefile.common
> @@ -71,3 +71,5 @@ test_cases: $(generated_files) $(tests-common) $(tests)
>
> $(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
> $(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
> +
> +$(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
> --
> 2.7.0.rc3.207.g0ac5344
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-03-04 18:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 21:41 [kvm-unit-tests] arm: fix parallel build (make -j) Peter Feiner
2016-03-04 11:04 ` Andrew Jones
2016-03-04 15:45 ` Paolo Bonzini
2016-03-04 16:28 ` Andrew Jones
2016-03-04 17:03 ` Peter Feiner
2016-03-04 17:04 ` [PATCH kvm-unit-tests v2] " Peter Feiner
2016-03-04 18:34 ` Andrew Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox