From: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
To: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH v2 0/9] cleanup around kvm_sync_page, and a few micro-optimizations
Date: Tue, 8 Mar 2016 17:00:27 +0900 [thread overview]
Message-ID: <56DE869B.9030908@lab.ntt.co.jp> (raw)
In-Reply-To: <1457360155-9610-2-git-send-email-pbonzini@redhat.com>
On 2016/03/07 23:15, Paolo Bonzini wrote:
> Having committed the ubsan fixes, this are the cleanups that are left.
>
> Compared to v1, I have fixed the patch to coalesce page zapping after
> mmu_sync_children (as requested by Takuya and Guangrong), and I have
> rewritten is_last_gpte again in an even simpler way.
>
> Paolo
>
> Paolo Bonzini (9):
> KVM: MMU: introduce kvm_mmu_flush_or_zap
> KVM: MMU: move TLB flush out of __kvm_sync_page
> KVM: MMU: use kvm_sync_page in kvm_sync_pages
> KVM: MMU: cleanup __kvm_sync_page and its callers
> KVM: MMU: invert return value of mmu.sync_page and *kvm_sync_page*
> KVM: MMU: move zap/flush to kvm_mmu_get_page
> KVM: MMU: coalesce more page zapping in mmu_sync_children
1-7 look good to me.
> KVM: MMU: simplify is_last_gpte
> KVM: MMU: micro-optimize gpte_access
8 and 9 look reasonable to me, though I read them only briefly.
Takuya
next prev parent reply other threads:[~2016-03-08 8:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 14:15 [PATCH v2 0/9] cleanup around kvm_sync_page, and a few micro-optimizations Paolo Bonzini
2016-03-07 14:15 ` Paolo Bonzini
2016-03-08 8:00 ` Takuya Yoshikawa [this message]
2016-03-08 8:30 ` Paolo Bonzini
2016-03-08 8:33 ` Takuya Yoshikawa
2016-03-07 14:15 ` [PATCH 1/9] KVM: MMU: introduce kvm_mmu_flush_or_zap Paolo Bonzini
2016-03-07 14:15 ` [PATCH 2/9] KVM: MMU: move TLB flush out of __kvm_sync_page Paolo Bonzini
2016-03-07 14:15 ` [PATCH 3/9] KVM: MMU: use kvm_sync_page in kvm_sync_pages Paolo Bonzini
2016-03-07 14:15 ` [PATCH 4/9] KVM: MMU: cleanup __kvm_sync_page and its callers Paolo Bonzini
2016-03-07 14:15 ` [PATCH 5/9] KVM: MMU: invert return value of mmu.sync_page and *kvm_sync_page* Paolo Bonzini
2016-03-07 14:15 ` [PATCH 6/9] KVM: MMU: move zap/flush to kvm_mmu_get_page Paolo Bonzini
2016-03-07 14:15 ` [PATCH 7/9] KVM: MMU: coalesce more page zapping in mmu_sync_children Paolo Bonzini
2016-03-07 14:15 ` [PATCH 8/9] KVM: MMU: simplify is_last_gpte Paolo Bonzini
2016-03-07 14:15 ` [PATCH 9/9] KVM: MMU: micro-optimize gpte_access Paolo Bonzini
2016-03-09 7:12 ` [PATCH v2 0/9] cleanup around kvm_sync_page, and a few micro-optimizations Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DE869B.9030908@lab.ntt.co.jp \
--to=yoshikawa_takuya_b1@lab.ntt.co.jp \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox