From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH kvm-unit-tests v2] powerpc: fix boot_rom.bin build Date: Tue, 8 Mar 2016 13:49:42 +0100 Message-ID: <56DECA66.4020205@redhat.com> References: <1457038529-4577-1-git-send-email-pfeiner@google.com> <1457111357-5809-1-git-send-email-pfeiner@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Peter Feiner , kvm@vger.kernel.org, drjones@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48679 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbcCHMtq (ORCPT ); Tue, 8 Mar 2016 07:49:46 -0500 In-Reply-To: <1457111357-5809-1-git-send-email-pfeiner@google.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/03/2016 18:09, Peter Feiner wrote: > My powerpc objcopy (version 2.23.52.20130305) did a seek() that > bash process substitution couldn't handle! I've changed the > Makefile to do things the old fashioned way. > > Signed-off-by: Peter Feiner > > --- > > v2: > * rm the temporary file > * renamed temporary file to .tmp instead of .suffix > --- > powerpc/Makefile.common | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common > index 424983e..2074289 100644 > --- a/powerpc/Makefile.common > +++ b/powerpc/Makefile.common > @@ -48,7 +48,9 @@ FLATLIBS = $(libcflat) $(LIBFDT_archive) > > $(TEST_DIR)/boot_rom.bin: $(TEST_DIR)/boot_rom.elf > dd if=/dev/zero of=$@ bs=256 count=1 > - $(OBJCOPY) -O binary $^ >(cat - >>$@) > + $(OBJCOPY) -O binary $^ $@.tmp > + cat $@.tmp >> $@ > + $(RM) $@.tmp > > $(TEST_DIR)/boot_rom.elf: CFLAGS = -mbig-endian > $(TEST_DIR)/boot_rom.elf: $(TEST_DIR)/boot_rom.o > Applied, thanks. Paolo