From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure Date: Wed, 9 Mar 2016 12:35:23 +0700 Message-ID: <56DFB61B.4040707@arm.com> References: <1457436573-6180-1-git-send-email-julien.grall@arm.com> <1457436573-6180-2-git-send-email-julien.grall@arm.com> <20160309032343.GE26583@lvm> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: al.stone@linaro.org, kvm@vger.kernel.org, marc.zyngier@arm.com, Daniel Lezcano , linux-kernel@vger.kernel.org, fu.wei@linaro.org, Thomas Gleixner , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org To: Christoffer Dall Return-path: In-Reply-To: <20160309032343.GE26583@lvm> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org Hi Christoffer, On 09/03/2016 10:23, Christoffer Dall wrote: > On Tue, Mar 08, 2016 at 11:29:25AM +0000, Julien Grall wrote: >> -static struct timecounter timecounter; >> +static struct arch_timer_kvm_info arch_timer_kvm_info; >> + >> +struct arch_timer_kvm_info *arch_timer_get_kvm_info(void) > > borderline bikeshedding question: > > does it make sense that the info the arch timer code exports is labeled > to be kvm-specific? In other words, could we imagine another subsystem > using this timer info some time and is there a more generic term that > would be more appropriate? I can't see any other usage. I would keep the function name KVM specific until someone really need similar information. Cheers, -- Julien Grall