From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC
Date: Wed, 9 Mar 2016 12:10:26 +0100
Message-ID: <56E004A2.70702@redhat.com>
References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com>
 <1457124368-2025-7-git-send-email-Suravee.Suthikulpanit@amd.com>
 <56DD9FF5.7010201@redhat.com> <20160308215424.GA31328@potion.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
	joro@8bytes.org, bp@alien8.de, gleb@kernel.org,
	alex.williamson@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, wei@redhat.com,
	sherry.hurwitz@amd.com
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:49673 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753156AbcCILKc (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 9 Mar 2016 06:10:32 -0500
In-Reply-To: <20160308215424.GA31328@potion.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 08/03/2016 22:54, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
> 2016-03-07 16:36+0100, Paolo Bonzini:
>> On 04/03/2016 21:46, Suravee Suthikulpanit wrote:
>>> +static void svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec)
>>> +{
>>> +	struct vcpu_svm *svm =3D to_svm(vcpu);
>>> +
>>> +	kvm_lapic_set_vector(vec, avic_get_bk_page_entry(svm, APIC_IRR));
>=20
> (I think that smp_mb here would make sense, even though we're fine no=
w
>  thanks to re-checking vcpu->mode in kvm_vcpu_kick.

Right, though only a smp_mb__after_atomic() is required (which is a
compiler barrier).  It is similarly required in vmx.

Offtopic remark, kvm_make_request() and kvm_check_request() should
probably have a smp_wmb() and a smp_rmb().

>>> +
>>> +	if (vcpu->mode =3D=3D IN_GUEST_MODE) {
>>> +		wrmsrl(SVM_AVIC_DOORBELL,
>>> +		       __default_cpu_present_to_apicid(vcpu->cpu));
>>> +	} else {
>>> +		kvm_vcpu_kick(vcpu);
>>> +	}
>>
>> You also need to add
>>
>> 	kvm_make_request(KVM_REQ_EVENT, vcpu);
>>
>> before the "if", similar to vmx_deliver_posted_interrupt.
>=20
> KVM won't do anything in KVM_REQ_EVENT and I think that the request c=
an
> be avoided because KVM already has to handle IRR writes from AVIC.

Doh, I've made the same remark already and you've given the same answer=
=2E :)

> And what about
>   [...]
>   else if (!vcpu->...->is_running)
>   	kvm_vcpu_kick(vcpu);
>=20
> ?
> The kick isn't needed unless the VCPU is scheduled out.
> Or maybe just
>   if (vcpu->...->is_running)
>     wrmsrl()
>   else
>     kvm_vcpu_kick();
> ?
> Which doesn't use the information we have on top AVIC, making our log=
ic
> a bit simpler.

Yes, both of this should work.  I like the latter.

In any case, the smp_mb__after_atomic() is necessary.

Paolo