From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: Remove redundant smp_mb() in the
 kvm_mmu_commit_zap_page()
Date: Thu, 10 Mar 2016 16:31:10 +0100
Message-ID: <56E1933E.20909@redhat.com>
References: <1457055312-27067-1-git-send-email-tianyu.lan@intel.com>
 <alpine.DEB.2.11.1603040820100.3597@nanos> <56D9354E.9040908@intel.com>
 <56D94BFE.1080406@redhat.com> <56DE8F1A.9000401@intel.com>
 <56DEEF69.20208@redhat.com> <56E1875E.8060007@linux.intel.com>
 <56E19224.9090906@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: gleb@kernel.org, mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	Lan Tianyu <tianyu.lan@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f44.google.com ([74.125.82.44]:36443 "EHLO
	mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752211AbcCJPbN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 10 Mar 2016 10:31:13 -0500
In-Reply-To: <56E19224.9090906@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 10/03/2016 16:26, Paolo Bonzini wrote:
> Compared to smp_load_acquire(), smp_mb() adds an ordering between stores
> and loads.

Here, the ordering is load-store, hence...

> The load of kvm->tlbs_dirty should then be
> 
> 	/*
> 	 * Read tlbs_dirty before setting KVM_REQ_TLB_FLUSH in
> 	 * kvm_make_all_cpus_request.  This
> 	 */
> 	long dirty_count = smp_load_acquire(kvm->tlbs_dirty);
> 
> Tianyu, I think Xiao provided the information that I was missing.  Would
> you like to prepare the patch?

Thanks,

Paolo