From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Vivier <lvivier@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v2 4/5] powerpc: check lswx
Date: Mon, 21 Mar 2016 16:59:43 +0100
Message-ID: <56F01A6F.7020002@redhat.com>
References: <1458560014-28862-1-git-send-email-lvivier@redhat.com>
 <1458560014-28862-5-git-send-email-lvivier@redhat.com>
 <56EFE3EA.5000900@redhat.com> <56F00471.6070801@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: drjones@redhat.com, dgibson@redhat.com
To: Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:56160 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756606AbcCUP7q (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 21 Mar 2016 11:59:46 -0400
In-Reply-To: <56F00471.6070801@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 21/03/2016 15:25, Paolo Bonzini wrote:
> 
> 
> On 21/03/2016 13:07, Thomas Huth wrote:
>>>> +		      /* adding r1 in the clobber list doesn't protect it... */
>> You repeat that again in the comment below, so in case you respin this
>> series, you could also drop one of the two comments, I think.
> 
> I can do it while fixing the typo (arount->around).

Yes, please.

Thanks,
Laurent
> 
> Paolo
> 
>>>> +		      "mr r29,r1;"
>>>> +		      "li r31,-1;"
>>>> +		      "mr r1,r31;"
>>>> +		      "mr r0, %[addr];"
>>>> +		      "lswx r31, 0, r0;"
>>>> +		      "std r31, 0*8(%[regs]);"
>>>> +		      "std r0, 1*8(%[regs]);"
>>>> +		      "std r1, 2*8(%[regs]);"
>>>> +		      "mr r1,r29;"
>>>> +		      ::
>>>> +		      [len] "r" (12),
>>>> +		      [addr] "r" (addr),
>>>> +		      [regs] "r" (regs)
>>>> +		      :
>>>> +		      /* three registers from r31, wrap arount to r1,