From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 3/4] KVM: MMU: reduce the size of mmu_page_path Date: Fri, 25 Mar 2016 14:45:39 +0100 Message-ID: <56F54103.6020508@redhat.com> References: <1458911978-19430-1-git-send-email-guangrong.xiao@linux.intel.com> <1458911978-19430-3-git-send-email-guangrong.xiao@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Xiao Guangrong Return-path: In-Reply-To: <1458911978-19430-3-git-send-email-guangrong.xiao@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 25/03/2016 14:19, Xiao Guangrong wrote: > Currently only PT64_ROOT_LEVEL - 1 levels are used, one additional entry > in .parent[] is used as a sentinel, the additional entry in .idx[] is > purely wasted > > This patch reduces its size and sets the sentinel on the upper level of > the place where we start from This patch and the previous one are basically redoing commit 0a47cd85833e ("KVM: MMU: Fix ubsan warnings", 2016-03-04). While you find your version easier to understand, I of course find mine easier. Rather than getting stuck in a ko fight, the solution is to stick with the code in KVM and add comments. I'll give it a try... Paolo