From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/4] KVM: MMU: fix permission_fault() Date: Fri, 25 Mar 2016 14:50:00 +0100 Message-ID: <56F54208.7020907@redhat.com> References: <1458911978-19430-1-git-send-email-guangrong.xiao@linux.intel.com> <56F53E87.6010304@redhat.com> <56F54027.3050001@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Xiao Guangrong Return-path: In-Reply-To: <56F54027.3050001@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 25/03/2016 14:41, Xiao Guangrong wrote: >>> >> >> So is this patch doing the same as "KVM: MMU: precompute page fault >> error code"? It was necessary after all. :) > > Sorry for my mistake... I missed the logic you changed :( > > I still prefer to calculating the error code on the fault path which is > rare, or think a way to encapsulate it to permission_fault()... Yes, I will apply your patch. Paolo